Improve user-facing error messages for clarity#95
Open
SLC-BTC wants to merge 1 commit intoBlockstream:masterfrom
Open
Improve user-facing error messages for clarity#95SLC-BTC wants to merge 1 commit intoBlockstream:masterfrom
SLC-BTC wants to merge 1 commit intoBlockstream:masterfrom
Conversation
Rewrite ~50 error messages across the string catalog and code to use
plain language, provide actionable guidance, and eliminate cryptic
technical jargon. Key changes:
- Replace generic messages like "Operation failure", "Failed", "Timeout"
with explanations of what went wrong and what to do next
- Fix grammar issues ("Could not recognized" -> "Could not recognize")
- Replace hardcoded English strings in Error.swift, Lwk.swift,
SendFlowError.swift, and BleLedgerConnection.swift with localization
keys so they can be properly translated
- Eliminate internal error names leaking to users ("Poison Error",
"Object Consumed", "Magic Routing Hint", "Reconnect Error")
- Tone down alarming hardware wallet error messages
- Add 8 new localization keys for previously unlocalized error strings
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error.swift,Lwk.swift,SendFlowError.swift, andBleLedgerConnection.swiftwith properid_localization keysExamples of changes
Companion PR: Blockstream/green_android (same branch name)
Test plan
🤖 Generated with Claude Code