fix(wasm-utxo): use BigInt-specific conversion for unspent values#211
Merged
OttoAllmendinger merged 2 commits intomasterfrom Mar 16, 2026
Merged
fix(wasm-utxo): use BigInt-specific conversion for unspent values#211OttoAllmendinger merged 2 commits intomasterfrom
OttoAllmendinger merged 2 commits intomasterfrom
Conversation
…nt values BigInt::from(value_js).as_f64() wraps a JsValue as a BigInt but then calls JsValue::as_f64(), which only returns Some(_) for JS Number — not BigInt. Any caller passing value: bigint (as typed) always gets "'value' must be a bigint". Issue: BTC-3159
Replace BigInt::from(v).as_f64() with u64::try_from(BigInt::unchecked_from_js(v)). unchecked_from_js treats the JsValue as a BigInt without re-wrapping it, then try_from converts directly to u64 — no lossy f64 round-trip and no false error when the caller correctly passes a JS bigint. Issue: BTC-3159
davidkaplanbitgo
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace BigInt::from(v).as_f64() with u64::try_from(BigInt::unchecked_from_js(v)).
unchecked_from_js treats the JsValue as a BigInt without re-wrapping it, then
try_from converts directly to u64 — no lossy f64 round-trip and no false error
when the caller correctly passes a JS bigint.
BigInt::from(value_js).as_f64() wraps a JsValue as a BigInt but then calls
JsValue::as_f64(), which only returns Some(_) for JS Number — not BigInt.
Any caller passing value: bigint (as typed) always gets "'value' must be a bigint".
Issue: BTC-3159