fix(toml/INI placeholders): (breaking) placeholders in generated toml and INI files#367
Merged
fix(toml/INI placeholders): (breaking) placeholders in generated toml and INI files#367
Conversation
BirdeeHub
changed the title
BirdeeHub
force-pushed
the
tomlplaceholders
branch
3 times, most recently
from
eede4cf to
808342f
Compare
BirdeeHub
changed the title
BirdeeHub
changed the title
made placeholders work in existing modules which generate toml files,
via the same method pkgs.formats uses, just directly in
config.constructFiles options instead.
This is a breaking change if you were accessing such files outside of
the module, and it is not possible to add a warning for this.
For all the modules with only 1 toml file, a read-only value exists in
config for each generated file under
`config.constructFiles.generatedConfig.outPath`, which may also be
grabbed from the package via
`passthru.configuration.constructFiles.generatedConfig.outPath`.
Or, for short,
`"${yourpackage.configuration.constructFiles.generatedConfig}"` (because
`passthru` is upvalued and interpolation accesses `.outPath`)
`helix` and `yazi` which both generate directories make a
`passthru.generatedConfig` value available to access the path from
outside of the module. The individual files also still have accessible
paths, under their respective names.
This change was applied to `alacritty`, `bottom`, `jujutsu`, `tealdeer`,
and `yazi`.
#367
cava, foot, fuzzel, mako, and notmuch all now use lib.generators ini generators instead. As in 808342f a read-only value exists in config for each generated file under `config.constructFiles.generatedConfig.outPath`, which may also be grabbed from the package via `passthru.configuration.constructFiles.generatedConfig.outPath`. Or, for short, `"${yourpackage.configuration.constructFiles.generatedConfig}"` (because `passthru` is upvalued and interpolation accesses `.outPath`)
BirdeeHub
force-pushed
the
tomlplaceholders
branch
from
5868721 to
c098c3f
Compare
BirdeeHub
added a commit
that referenced
this pull request
Mar 24, 2026
made placeholders work in existing modules which generate toml files,
via the same method pkgs.formats uses, just directly in
config.constructFiles options instead.
This is a breaking change if you were accessing such files outside of
the module, and it is not possible to add a warning for this.
For all the modules with only 1 toml file, a read-only value exists in
config for each generated file under
`config.constructFiles.generatedConfig.outPath`, which may also be
grabbed from the package via
`passthru.configuration.constructFiles.generatedConfig.outPath`.
Or, for short,
`"${yourpackage.configuration.constructFiles.generatedConfig}"` (because
`passthru` is upvalued and interpolation accesses `.outPath`)
`helix` and `yazi` which both generate directories make a
`passthru.generatedConfig` value available to access the path from
outside of the module. The individual files also still have accessible
paths, under their respective names.
This change was applied to `alacritty`, `bottom`, `jujutsu`, `tealdeer`,
and `yazi`.
#367
This was referenced Mar 24, 2026
BirdeeHub
added a commit
that referenced
this pull request
Mar 24, 2026
placeholders are now usable in all options for `niri`, `opencode`, `nushell`, and `ov` Same benefits and drawbacks as the last 2 commits, (This PR #367) just for more modules From outside of the module, grab the path via `config.constructFiles.generatedConfig.outPath` Still to go: `rofi`, `waybar`, `claude-code`, `btop` and `mpv` modules After that, everything that could reasonably support it will have this capability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
made placeholders work in existing modules which generate toml files, via the same method pkgs.formats uses, just directly in config.constructFiles options instead.
This is a breaking change if you were accessing such files outside of the module, and it is not possible to add a warning for this.
For all the modules with only 1 toml file, a read-only value exists in config for each generated file under
config.constructFiles.generatedConfig.outPath, which may also be grabbed from the package viapassthru.configuration.constructFiles.generatedConfig.outPath.Or, for short,
"${yourpackage.configuration.constructFiles.generatedConfig}"(becausepassthruis upvalued and interpolation accesses.outPath)helixandyaziwhich both generate directories make apassthru.generatedConfigvalue available to access the path from outside of the module. The individual files also still have accessible paths, under their respective names.This change was applied to
alacritty,bottom,jujutsu,tealdeer, andyazi.The same change occurred for the ones generated via
pkgs.formats.iniThose being:
cava,foot,fuzzel,mako, andnotmuch.All only generate 1 file, which you can use from within the module via a read-only option under
config.constructFiles.generatedConfig.outPath, which may also be grabbed from the package viapassthru.configuration.constructFiles.generatedConfig.outPath.Or, for short,
"${yourpackage.configuration.constructFiles.generatedConfig}"(becausepassthruis upvalued and interpolation accesses.outPath)