Explain how to comply with the FAIR chemical structures specification#658
Open
Explain how to comply with the FAIR chemical structures specification#658
Conversation
Contributor
|
The JSON file above displays fine in the DDE, but getting it to propagate to the website is another story (see #643) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal reference
#657 and #639
Description
A the BioHackathon Europe 2022 this was discussed with @AlasdairGray and Evan Bolton. Since then, the properties have been made optional, but the explanation in the description never got in.
Motivation and context
Have these been tested?
No.
What should reviewers focus on?
That the JSON is correct. I tried using the DDE, which sort of worked, but the JSON was so much different, even though I did start with the DDE version of 0.7-DRAFT that I went for the JSON in this repo.
Types of changes
Future TO-DOs