Conversation
ljgarcia
left a comment
ljgarcia
left a comment
There was a problem hiding this comment.
Some links are broken and latest release for Protein is 11, better to use the latest release and not an old draft.
| "identifier": "stringdb", | ||
| "@type": "DataCatalog", | ||
| "@id": "https://string-db.org/", | ||
| "http://purl.org/dc/terms/conformsTo": "https://bioschemas.org/specifications/DataCatalog/0.3", |
There was a problem hiding this comment.
This link https://bioschemas.org/specifications/DataCatalog/0.3 does not work, the link should be https://bioschemas.org/profiles/DataCatalog/0.3-RELEASE-2019_07_01/
| { | ||
| "@type": "Dataset", | ||
| "@id": "https://string-db.org/#string.v11", | ||
| "http://purl.org/dc/terms/conformsTo": "https://bioschemas.org/specifications/Dataset/0.3", |
There was a problem hiding this comment.
| "license": { | ||
| "@type": "CreativeWork", | ||
| "name": "Creative Commons Attribution 4.0 International", | ||
| "url": "https://creativecommons.org/licenses/by/4.0/" |
There was a problem hiding this comment.
Should not we use this URL as the "@id" as well?
| "@type": "Dataset", | ||
| "@type": "bio:DataRecord", | ||
| "@id": "https://string-db.org/network/9606.ENSP00000379258", | ||
| "http://purl.org/dc/terms/conformsTo": "https://bioschemas.org/specifications/DataRecord/0.2-DRAFT", |
There was a problem hiding this comment.
| ], | ||
| "@type": "bio:Protein", | ||
| "@id": "https://string-db.org/network/9606.ENSP00000379258", | ||
| "http://purl.org/dc/terms/conformsTo": "https://bioschemas.org/specifications/Protein/0.9-DRAFT", |
There was a problem hiding this comment.
The currentProtein profile version is https://bioschemas.org/profiles/Protein/0.11-RELEASE/ should it not be better to update the example to the latest release rather than using an old DRAFT profile?
2 participants
Pull request updates the string-db markup to comply with the latest profiles for Bioschemas.