Conversation
awilfox
requested review from
anarchivist,
danschmidt5189,
davezuckerman and
jason-raitz
This was meant to be done a long time ago, but it was lost in a Git stash. (Sorry!) This is needed to make sure the updater service doesn't continually fail when it is run. Ref: AP-558
awilfox
force-pushed
the
awilfox/AP-558-idempotent-sql
branch
from
10ec14c to
a471a45
Compare
|
v2: Ensure primary/foreign key constraints are part of table creation. |
danschmidt5189
left a comment
danschmidt5189
left a comment
There was a problem hiding this comment.
Looks good, thanks for cleaning this up. Conditionally +1 assuming that this has actually been tested! (Does the test suite load/cover this?)
The test suite doesn't cover any of the UI, unfortunately. Unlike Ruby, Python doesn't have a Capybara that the community all likes and uses and coalesces around. (There is Splinter but it's very heavy.) I spun up a new instance of Willa locally and ran the script a few times to ensure that it created it properly (and the app functioned) and then was idempotent (and the app remained functional). |
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
r+!
The test suite doesn't cover any of the UI, unfortunately. Unlike Ruby, Python doesn't have a Capybara that the community all likes and uses and coalesces around. (There is Splinter but it's very heavy.)
fwiw, Chainlit's UI testing is all done using Cypress: https://github.com/Chainlit/chainlit/tree/main/cypress
3 participants
This was meant to be done a long time ago, but it was lost in a Git stash. (Sorry!) This is needed to make sure the updater service doesn't continually fail when it is run.
Ref: AP-558