Conversation
Edit compatibility for amharic in Google colab
Codecov Report
@@ Coverage Diff @@
## amharic #168 +/- ##
===========================================
+ Coverage 66.00% 66.85% +0.85%
===========================================
Files 6 6
Lines 350 347 -3
===========================================
+ Hits 231 232 +1
+ Misses 119 115 -4
Continue to review full report at Codecov.
|
Belval
left a comment
Belval
left a comment
There was a problem hiding this comment.
Can you provide some samples to show that it works?
| image_name = '{}_{}.{}'.format(text, str(index), extension) | ||
|
|
||
|
|
||
| image_name = '{}.{}'.format(str(uuid.uuid4()),extension) |
There was a problem hiding this comment.
Was this added to the PR by mistake? I can't really change the behavior of TRDG like that.
There was a problem hiding this comment.
yes, sorry, this was added by mistake, I was working on make TRDG available for amharic language and it printed blank images, so I made changes which involved adding a new font for amharic & removing the name factor as utf-8 based file names were saved as "", which happened to clash with my own configuration. i hope it didn't cause any harm.
3 participants
Update the main version of TRDG