IA-4883 iconProps should be optional while creating a dialog#2835
Merged
beygorghor merged 1 commit intodevelopfrom Mar 20, 2026
Merged
IA-4883 iconProps should be optional while creating a dialog#2835beygorghor merged 1 commit intodevelopfrom
beygorghor merged 1 commit intodevelopfrom
Conversation
Bewi
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
iconProps is required while using makeFullMal, and shouldn't, it raises an TS error on iaso side if not set
Related JIRA tickets
IA-4883
Changes
Make iconProps optional on bluesquare-components
How to test
Run
npm cimake sure it build and that TS is not complaining if iconProps