Skip to content

Upgrade project files to SDK-style format compatible with dotnet#326

Merged
michaelhoehn merged 2 commits intodevelopfrom
Versioning_Toolkit-#325-ProjectFormatUpgrade
Mar 12, 2026
Merged

Upgrade project files to SDK-style format compatible with dotnet#326
michaelhoehn merged 2 commits intodevelopfrom
Versioning_Toolkit-#325-ProjectFormatUpgrade

Conversation

@adecler
Copy link
Member

@adecler adecler commented Feb 24, 2026

Issues addressed by this PR

Fixes #325

  • The project files were still using the legacy .NET Framework project files and needed to be upgraded to SDK-style format compatible with dotnet.
  • I have not upgraded the framework to netstandard2.0 as I was not confident this would be compatible for this repo and its dependencies.

Tests

  • Make sure the solution build with dotnet build
  • Run your end of milestone testing procedure

@adecler adecler requested a review from michaelhoehn February 24, 2026 16:43
@adecler adecler self-assigned this Feb 24, 2026
@adecler adecler added the type:compliance Non-conforming to code guidelines label Feb 24, 2026
@adecler
Copy link
Member Author

adecler commented Feb 24, 2026

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 24, 2026

@adecler to confirm, the following actions are now queued:

  • check project-compliance

@adecler
Copy link
Member Author

adecler commented Feb 25, 2026

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2026

@adecler to confirm, the following actions are now queued:

  • check installer

Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions as expected. Happy to go for merge.

@michaelhoehn
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 12, 2026

@michaelhoehn to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@michaelhoehn michaelhoehn merged commit ca23d0b into develop Mar 12, 2026
5 checks passed
@michaelhoehn michaelhoehn deleted the Versioning_Toolkit-#325-ProjectFormatUpgrade branch March 12, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:compliance Non-conforming to code guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade project files to SDK-style format compatible with dotnet

2 participants