Skip to content

Conversation

@rujche
Copy link
Member

@rujche rujche commented Jan 23, 2026

@rujche rujche requested a review from alzimmermsft as a code owner January 23, 2026 09:13
Copilot AI review requested due to automatic review settings January 23, 2026 09:13
@rujche rujche marked this pull request as draft January 23, 2026 09:13
@rujche rujche self-assigned this Jan 23, 2026
@rujche
Copy link
Member Author

rujche commented Jan 23, 2026

/azp run java - spring - tests

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Jan 23, 2026
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes failing Spring integration tests by aligning the Netty version used in the spring-cloud-azure-integration-tests module with the Azure SDK’s supported Netty line, overriding Spring Boot’s newer Netty dependency.

Changes:

  • Add a <dependencyManagement> section in spring-cloud-azure-integration-tests/pom.xml to import io.netty:netty-bom:4.1.130.Final, forcing Netty 4.1.x instead of Spring Boot 4.x’s 4.2.x line.
  • Register io.netty:netty-bom;4.1.130.Final in eng/versioning/external_dependencies.txt to keep Netty dependency versions centrally tracked and consistent.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/spring/spring-cloud-azure-integration-tests/pom.xml Imports netty-bom via dependencyManagement to enforce a Netty 4.1.x version compatible with Azure SDK and unblock the failing integration tests.
eng/versioning/external_dependencies.txt Adds io.netty:netty-bom at 4.1.130.Final to the central external dependency version list, aligning with the POM change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants