-
Notifications
You must be signed in to change notification settings - Fork 267
Expose optional configuration for prompt.PromptResourceGroup
#6583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds optional configuration support for the PromptResourceGroup gRPC API, enabling extension developers to customize the resource group selection experience through PromptResourceGroupOptions.
Changes:
- Added
PromptResourceGroupOptionsprotobuf message with nestedPromptResourceSelectOptions - Extended
PromptResourceSelectOptionswithhintandenable_filteringfields - Created
MockPromptServicefor testing and comprehensive test coverage
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cli/azd/grpc/proto/prompt.proto | Added PromptResourceGroupOptions message and extended PromptResourceSelectOptions with hint and enable_filtering fields |
| cli/azd/pkg/azdext/prompt.pb.go | Generated protobuf code for new message types and fields |
| cli/azd/internal/grpcserver/prompt_service.go | Added createResourceGroupOptions helper and updated PromptResourceGroup to propagate options |
| cli/azd/internal/grpcserver/prompt_service_test.go | Comprehensive unit tests covering NoPrompt mode, options propagation, and helper functions |
| cli/azd/test/mocks/mockprompt/mock_prompt_service.go | New mock implementation for testing prompt service functionality |
| cli/azd/extensions/microsoft.azd.demo/internal/cmd/prompt.go | Example usage demonstrating how to disable resource group creation |
| cli/azd/.vscode/cspell.yaml | Added "cmds" to dictionary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Summary
Adds support for
PromptResourceGroupOptionsin thePromptResourceGroupgRPC API, enabling extensions to customize the resource group selection experience (e.g., hide/show "Create new resource group" option).Fixes #6571
Business Value
Enables extension developers to build better user experiences by giving them control over the resource group prompt behavior. Key use cases:
PromptSubscriptionResource,PromptResourceGroupResource)Changes
Proto API
PromptResourceGroupOptionsmessage with nestedPromptResourceSelectOptionsoptionsfield toPromptResourceGroupRequestPromptResourceSelectOptionswith missing fields:hint,enable_filteringImplementation
createResourceGroupOptions()helper functionTesting
MockPromptServicein mockpromptmock.MatchedByBreaking Changes
None - new optional field is backward compatible.