Conversation
a0x1ab
requested review from
bebound,
calvinhzy,
jiasli,
kairu-ms,
naga-nandyala and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges release 2.84.0 back to the dev branch, specifically incorporating PR #32847 which fixes CredScan false positives. The change adds three suppressions for dummy credential values used in ARO (Azure Red Hat OpenShift) unit tests to prevent the CredScan tool from flagging these harmless test strings as security issues.
Changes:
- Added three CredScan suppressions for placeholder test values (
asdfghjkl,secret_123,client_id_456) used in ARO test_validators.py unit tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
naga-nandyala
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge fix #32847 back to
dev.🛑 Don't squash merge but merge it locally and push.