{AKS} fix InvalidParameter error when add Machines nodepool#9689
{AKS} fix InvalidParameter error when add Machines nodepool#9689HuShaoRu wants to merge 3 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @HuShaoRu, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
Fixes az aks nodepool add --mode=Machines failing with InvalidParameter by ensuring Machines-mode nodepools are created with only supported properties, and updates tests accordingly.
Changes:
- Add Machines-mode handling in the agentpool decorator to reset/bypass unsupported fields when
mode=Machines. - Update scenario/unit tests to cover Machines-mode behavior and remove redundant scenario coverage.
- Update changelog entry for the fix and remove an obsolete test recording.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/agentpool_decorator.py | Adds Machines-mode setup and skips other property setup when mode is Machines. |
| src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py | Adds unit test coverage for Machines-mode behavior in the decorator. |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Consolidates/updates scenario coverage for Machines nodepools and machine operations. |
| src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_create_machines_pool.yaml | Removes recording for a deleted redundant scenario test. |
| src/aks-preview/HISTORY.rst | Adds release note entry describing the Machines-mode InvalidParameter fix. |
You can also share your feedback on Copilot code review. Take the survey.
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py
Outdated
Show resolved
Hide resolved
FumingZhang
left a comment
There was a problem hiding this comment.
lgtm
Queued live test to validate the change.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks nodepool add --mode=Machines: remove unsupported fields when mode=Machinesalso remove redundant live tests for Machines nodepools.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.