Skip to content

{AKS} fix InvalidParameter error when add Machines nodepool#9689

Open
HuShaoRu wants to merge 3 commits intoAzure:mainfrom
HuShaoRu:machinesapi
Open

{AKS} fix InvalidParameter error when add Machines nodepool#9689
HuShaoRu wants to merge 3 commits intoAzure:mainfrom
HuShaoRu:machinesapi

Conversation

@HuShaoRu
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks nodepool add --mode=Machines: remove unsupported fields when mode=Machines
also remove redundant live tests for Machines nodepools.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings March 16, 2026 21:52
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Mar 16, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @HuShaoRu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 16, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes az aks nodepool add --mode=Machines failing with InvalidParameter by ensuring Machines-mode nodepools are created with only supported properties, and updates tests accordingly.

Changes:

  • Add Machines-mode handling in the agentpool decorator to reset/bypass unsupported fields when mode=Machines.
  • Update scenario/unit tests to cover Machines-mode behavior and remove redundant scenario coverage.
  • Update changelog entry for the fix and remove an obsolete test recording.

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/aks-preview/azext_aks_preview/agentpool_decorator.py Adds Machines-mode setup and skips other property setup when mode is Machines.
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py Adds unit test coverage for Machines-mode behavior in the decorator.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Consolidates/updates scenario coverage for Machines nodepools and machine operations.
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_create_machines_pool.yaml Removes recording for a deleted redundant scenario test.
src/aks-preview/HISTORY.rst Adds release note entry describing the Machines-mode InvalidParameter fix.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Queued live test to validate the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants