Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @ayush-ms, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Validated
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull request overview
Refines the user-facing error message raised by ConfigurationHelper.getConfigurationId() when no configuration can be resolved from the provided hierarchy resource ID, aiming to provide more specific guidance for Target vs Site IDs in the workload-orchestration extension.
Changes:
- Adds Target/Site-specific
CLIInternalErrormessages when configuration lookup fails. - Replaces the previous generic “No configuration linked…” message with an ID-type validation message for non-Target/Site hierarchy IDs.
You can also share your feedback on Copilot code review. Take the survey.
| if "microsoft.edge/targets" in hierarchy_id_str.lower(): | ||
| raise CLIInternalError( | ||
| f"Missing target configuration and configuration reference for Target: {hierarchy_id_str}" | ||
| ) | ||
| elif "microsoft.edge/sites" in hierarchy_id_str.lower(): | ||
| raise CLIInternalError( | ||
| f"Missing site configuration and configuration reference for Site: {hierarchy_id_str}" | ||
| ) |
| ) | ||
| else: | ||
| raise CLIInternalError( | ||
| f"Hierarchy Id can either be of Target or Site Resource. Invalid Id: {hierarchy_id_str}" |
|
Hi @ayush-ms Release SuggestionsModule: workload-orchestration
Notes
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.