Skip to content

standbypool: upgrade to API version 2025-10-01#9682

Open
carlosh-msft2025 wants to merge 1 commit intoAzure:mainfrom
carlosh-msft2025:standbypool-2025-10-01
Open

standbypool: upgrade to API version 2025-10-01#9682
carlosh-msft2025 wants to merge 1 commit intoAzure:mainfrom
carlosh-msft2025:standbypool-2025-10-01

Conversation

@carlosh-msft2025
Copy link
Member

Description

Upgrade the StandbyPool CLI extension from API version 2025-03-01 to 2025-10-01 (stable).

Changes

  • Regenerate all 14 CLI commands from 2025-10-01 stable swagger
  • Add DynamicSizing support (--dynamic-sizing-enabled) for both VM and container group pools
  • Add PostProvisioningDelay support (--post-provisioning-delay / --provision-delay) for VM pools
  • Remove maxReadyCapacity max=2000 constraint
  • Bump extension version to 3.0.0

Testing

  • azdev style standbypool - PASSED
  • azdev linter standbypool - PASSED
  • Live test recording + playback - 2 passed

Related

  • API spec: standbypool-2025-10-01
  • aaz PR: (to follow)

This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI review requested due to automatic review settings March 12, 2026 22:40
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 12, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the standbypool Azure CLI extension to the 2025-10-01 management-plane API, regenerating AAZ command implementations and updating scenarios/recordings to validate new API surface (notably DynamicSizing and PostProvisioningDelay) while bumping the extension major version.

Changes:

  • Bump extension version to 3.0.0 and raise min CLI core requirement.
  • Regenerate Standby VM Pool and Standby Container Group Pool AAZ commands for api-version=2025-10-01, adding --dynamic-sizing-enabled and VM pool --post-provisioning-delay/--provision-delay.
  • Update scenario tests and recordings to reflect new request/response shape and new flags.

Reviewed changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/standbypool/setup.py Bumps extension package version to 3.0.0.
src/standbypool/HISTORY.rst Adds 3.0.0 changelog entry describing API bump and new flags.
src/standbypool/azext_standbypool/azext_metadata.json Raises azext.minCliCoreVersion to 2.75.0.
src/standbypool/azext_standbypool/tests/latest/test_standbypool.py Updates scenario tests to use subscription-scoped IDs and validate new elasticity properties.
src/standbypool/azext_standbypool/tests/latest/recordings/test_standby_virtual_machine_pool_scenarios.yaml Updates live-test recording to new CLI/runtime + new API/fields.
src/standbypool/azext_standbypool/aaz/latest/standby_vm_pool/_create.py Regenerated standby-vm-pool create for 2025-10-01; adds dynamic sizing + post provisioning delay.
src/standbypool/azext_standbypool/aaz/latest/standby_vm_pool/_update.py Regenerated standby-vm-pool update with no-wait + generic-update flow and new properties.
src/standbypool/azext_standbypool/aaz/latest/standby_vm_pool/_show.py Updates show schema and API version; includes new elasticity properties in schema.
src/standbypool/azext_standbypool/aaz/latest/standby_vm_pool/_list.py Updates list commands to 2025-10-01 and extends response schema for new properties.
src/standbypool/azext_standbypool/aaz/latest/standby_vm_pool/_delete.py Updates delete command API version and examples.
src/standbypool/azext_standbypool/aaz/latest/standby_vm_pool/_status.py Updates runtime view API version and examples.
src/standbypool/azext_standbypool/aaz/latest/standby_vm_pool/_wait.py Updates wait command API version and response schema.
src/standbypool/azext_standbypool/aaz/latest/standby_container_group_pool/_create.py Regenerated standby-container-group-pool create for 2025-10-01; adds dynamic sizing.
src/standbypool/azext_standbypool/aaz/latest/standby_container_group_pool/_update.py Regenerated standby-container-group-pool update with no-wait + generic-update flow and dynamic sizing.
src/standbypool/azext_standbypool/aaz/latest/standby_container_group_pool/_show.py Updates show schema and API version; includes dynamic sizing in schema.
src/standbypool/azext_standbypool/aaz/latest/standby_container_group_pool/_list.py Updates list commands to 2025-10-01 and extends response schema for new properties.
src/standbypool/azext_standbypool/aaz/latest/standby_container_group_pool/_delete.py Updates delete command API version and examples.
src/standbypool/azext_standbypool/aaz/latest/standby_container_group_pool/_status.py Updates runtime view API version and examples.
src/standbypool/azext_standbypool/aaz/latest/standby_container_group_pool/_wait.py Updates wait command API version and response schema.

_element = cls._args_schema.subnet_ids.Element
_element.id = AAZResourceIdArg(
options=["id"],
help="Specifies ARM resource id of the subnet.",
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the update command schema, the subnet id element is no longer marked as required. If a user supplies --subnet-ids, allowing elements without an id will defer validation until the service call (or potentially send an invalid payload). Consider restoring required=True for the id field on each subnet element (even if the overall --subnet-ids argument remains optional/nullable).

Suggested change
help="Specifies ARM resource id of the subnet.",
help="Specifies ARM resource id of the subnet.",
required=True,

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Mar 12, 2026
- Regenerate all CLI commands from 2025-10-01 stable swagger
- Add DynamicSizing support (--dynamic-sizing-enabled) for VM and container group pools
- Add PostProvisioningDelay support (--post-provisioning-delay) for VM pools
- Remove maxReadyCapacity max=2000 constraint
- Bump extension version to 3.0.0
- Update tests and re-record test recordings
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Mar 12, 2026
@yonzhan yonzhan requested review from jsntcy and necusjz March 12, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants