Skip to content

feat: add disable_artifact_streaming arg for nodepool update in aks preview#9679

Open
KananMehta wants to merge 3 commits intoAzure:mainfrom
KananMehta:kananmehta/artifactstreaming-cli-update
Open

feat: add disable_artifact_streaming arg for nodepool update in aks preview#9679
KananMehta wants to merge 3 commits intoAzure:mainfrom
KananMehta:kananmehta/artifactstreaming-cli-update

Conversation

@KananMehta
Copy link

@KananMehta KananMehta commented Mar 12, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @KananMehta,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 12, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

@yonzhan yonzhan requested a review from yanzhudd March 12, 2026 23:51
@KananMehta KananMehta force-pushed the kananmehta/artifactstreaming-cli-update branch from f808ffd to be0be62 Compare March 16, 2026 15:03
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Mar 16, 2026
@KananMehta KananMehta force-pushed the kananmehta/artifactstreaming-cli-update branch from 46897d9 to a87ac17 Compare March 16, 2026 15:19
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Mar 16, 2026
@KananMehta KananMehta marked this pull request as ready for review March 16, 2026 15:27
Copilot AI review requested due to automatic review settings March 16, 2026 15:27
@KananMehta KananMehta changed the title feat: add disable_artifact_streaming arg feat: add disable_artifact_streaming arg for nodepool update in aks preview Mar 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the aks-preview Azure CLI extension to support explicitly disabling artifact streaming on AKS nodepools via az aks nodepool update, including validation, wiring into the agentpool decorator, help text, and tests.

Changes:

  • Add --disable-artifact-streaming to az aks nodepool update (params, help, decorator update logic).
  • Add/extend validation to enforce mutual exclusivity with --enable-artifact-streaming and restrict usage to Linux nodepools.
  • Update unit tests, linter exclusions, changelog, and bump extension version to 19.0.0b26.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/aks-preview/setup.py Bumps extension version to 19.0.0b26.
src/aks-preview/linter_exclusions.yml Adds linter exclusion entry for the new disable_artifact_streaming parameter.
src/aks-preview/HISTORY.rst Documents the new --disable-artifact-streaming flag in Pending.
src/aks-preview/azext_aks_preview/tests/latest/test_validators.py Adds validator coverage for --disable-artifact-streaming and mutual exclusivity.
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py Adds decorator/context tests for reading and applying disable_artifact_streaming.
src/aks-preview/azext_aks_preview/custom.py Adds the new parameter to the aks_agentpool_update custom command signature.
src/aks-preview/azext_aks_preview/agentpool_decorator.py Adds context getter and update logic to set artifact_streaming_profile.enabled = False.
src/aks-preview/azext_aks_preview/_validators.py Enhances validation for mutual exclusivity and Windows OS restriction.
src/aks-preview/azext_aks_preview/_params.py Registers the new CLI argument for aks nodepool update.
src/aks-preview/azext_aks_preview/_help.py Adds help entry for --disable-artifact-streaming.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants