List instances and List revision should use ST Id not name#9643
List instances and List revision should use ST Id not name#9643Avisiktapatra wants to merge 20 commits intoAzure:mainfrom
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Avisiktapatra, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This PR updates workload-orchestration target listing commands to use the solution template’s uniqueIdentifier (ST Id) instead of the template name when calling the target “solutions” list endpoints, to align with the service’s expected identifier.
Changes:
- Add a shared
TargetHelper.get_solution_template_unique_identifier(...)to fetch a solution template and extractproperties.uniqueIdentifier. - Update
target solution-instance-listto resolve and useuniqueIdentifierfor thesolutionNamepath segment. - Update
target solution-revision-listto resolve and useuniqueIdentifierfor thesolutionNamepath segment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/workload-orchestration/azext_workload_orchestration/aaz/latest/workload_orchestration/target/_target_helper.py |
New helper for resolving solution template uniqueIdentifier via a GET on solutionTemplates. |
src/workload-orchestration/azext_workload_orchestration/aaz/latest/workload_orchestration/target/_solution_instance_list.py |
Uses resolved uniqueIdentifier in URL params for listing solution instances. |
src/workload-orchestration/azext_workload_orchestration/aaz/latest/workload_orchestration/target/_solution_revision_list.py |
Uses resolved uniqueIdentifier in URL params for listing solution revisions. |
...tion/azext_workload_orchestration/aaz/latest/workload_orchestration/target/_target_helper.py
Outdated
Show resolved
Hide resolved
...tion/azext_workload_orchestration/aaz/latest/workload_orchestration/target/_target_helper.py
Show resolved
Hide resolved
| def __call__(self, *args, **kwargs): | ||
| # Resolve solution template name to its uniqueIdentifier | ||
| self.unique_identifier = TargetHelper.get_solution_template_unique_identifier( | ||
| self.ctx.subscription_id, | ||
| self.ctx.args.resource_group, | ||
| self.ctx.args.solution_name, | ||
| self.client | ||
| ) | ||
|
|
||
| request = self.make_request() |
There was a problem hiding this comment.
The new behavior adds an extra management-plane GET to resolve the solution template uniqueIdentifier before listing instances, but there’s no scenario coverage for this command path in the extension tests. Adding/adjusting a scenario test to exercise workload-orchestration target solution-instance-list (including the extra solutionTemplates GET) would help prevent regressions.
...t_workload_orchestration/aaz/latest/workload_orchestration/target/_solution_revision_list.py
Show resolved
Hide resolved
…test/workload_orchestration/target/_target_helper.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…test/workload_orchestration/target/_target_helper.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
...t_workload_orchestration/aaz/latest/workload_orchestration/target/_solution_instance_list.py
Outdated
Show resolved
Hide resolved
...t_workload_orchestration/aaz/latest/workload_orchestration/target/_solution_revision_list.py
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Add new command for capability updates on ST






This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.