[ACR] add new acrregionalendpoint extension for private preview of ACR Regional Endpoints feature by lizMSFT · Pull Request #9500 · Azure/azure-cli-extensions

lizMSFT · 2026-01-06T22:09:31Z

DO NOT MERGE

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az acr create/update/show
az acr show-endpoints
az acr login
az acr import

Description

Changes Introduced:

Initial preview release for Azure Container Registry regional endpoints support.
Add: --regional-endpoints parameter to az acr create and az acr update commands to enable regional endpoint functionality.
Add: --endpoint parameter to az acr login command to authenticate against a specific regional endpoint.
Add: Enhanced az acr show command to display regionalEndpoints and regionalEndpointHostNames properties in registry information.
Add: Enhanced az acr show-endpoints command to display comprehensive endpoint information including registry login server, data endpoints, and regional endpoints.
Add: Enhanced az acr import command to automatically detect and handle regional endpoint URIs in source image specifications.

Testing

az acr create:

az acr update:

az acr show:

az acr show-endpoints:

az acr login:

az acr import:

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

…R Regional Endpoints feature

azure-client-tools-bot-prd · 2026-01-06T22:09:37Z

Validation for Breaking Change Starting...

Thanks for your contribution!

azure-client-tools-bot-prd · 2026-01-06T22:09:40Z

Hi @lizMSFT,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2026-01-06T22:09:43Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2026-01-06T22:09:45Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2026-01-06T22:13:04Z

For more info about extension versioning, please refer to Extension version schema

Copilot

Pull request overview

This pull request adds a new Azure CLI extension called "acrregionalendpoint" for the private preview of the ACR Regional Endpoints feature. The extension provides management capabilities for Azure Container Registry regional endpoints.

Key changes:

New extension scaffolding with version 1.0.0
Vendored Azure Container Registry Management SDK
Support for API version 2025-12-01-preview

Reviewed changes

Copilot reviewed 38 out of 43 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
setup.py	Extension metadata, dependencies, and packaging configuration
azext_metadata.json	Extension configuration marking it as preview with minimum CLI version 2.80.0
vendored_sdks/containerregistry/	Auto-generated Container Registry Management SDK code
_configuration.py (sync/async)	SDK configuration with API version 2025-12-01-preview
models/	Auto-generated model classes and enums for the SDK
operations/	Auto-generated operation classes for SDK functionality
tests/	Test structure setup (placeholder files)

lizMSFT · 2026-01-07T04:06:09Z

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py

@@ -0,0 +1,401 @@
+# --------------------------------------------------------------------------------------------


Reference: https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/acr/custom.py

lizMSFT · 2026-01-07T04:06:53Z

src/acrregionalendpoint/azext_acrregionalendpoint/import.py

@@ -0,0 +1,184 @@
+# --------------------------------------------------------------------------------------------


Reference: https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/acr/import.py

src/acrregionalendpoint/azext_acrregionalendpoint/_params.py

Copilot

Pull request overview

Copilot reviewed 38 out of 43 changed files in this pull request and generated 8 comments.

src/acrregionalendpoint/azext_acrregionalendpoint/_params.py

...regionalendpoint/azext_acrregionalendpoint/vendored_sdks/containerregistry/_configuration.py

...onalendpoint/azext_acrregionalendpoint/vendored_sdks/containerregistry/aio/_configuration.py

src/acrregionalendpoint/azext_acrregionalendpoint/tests/latest/recordings/test_acr_login.yaml

...egionalendpoint/tests/latest/recordings/test_acr_create_with_regional_endpoint_disabled.yaml

...regionalendpoint/tests/latest/recordings/test_acr_create_with_regional_endpoint_enabled.yaml

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py

Copilot

Pull request overview

Copilot reviewed 38 out of 43 changed files in this pull request and generated 2 comments.

src/acrregionalendpoint/azext_acrregionalendpoint/import.py

...egionalendpoint/azext_acrregionalendpoint/tests/latest/test_acr_regionalendpoint_scenario.py

lizMSFT · 2026-02-02T20:49:54Z

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py

+
+    return info
+
+


Copied the functions below from azure.cli.command_modules.acr.custom due to potential upcoming changes on the CLI side.

More details in: Azure/azure-sdk-for-python#44775 (comment)

…ands test

huanwu

submit comment

src/acrregionalendpoint/azext_acrregionalendpoint/_help.py

src/acrregionalendpoint/azext_acrregionalendpoint/_params.py

src/acrregionalendpoint/azext_acrregionalendpoint/_help.py

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py

huanwu

post review comments

yanzhudd · 2026-02-08T23:50:08Z

/azp run

azure-pipelines · 2026-02-08T23:50:23Z

Azure Pipelines successfully started running 2 pipeline(s).

savaradh · 2026-02-09T18:29:30Z

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py

+                       dnl_scope=None,
+                       role_assignment_mode=None,
+                       regional_endpoints=None):
+    from azure.cli.command_modules.acr.custom import (_create_diagnostic_settings)


Just curious, what does this one do? Do we need this here?

_create_diagnostic_settings is used on line 110. The original az acr create command supports this functionality:

--workspace [Preview] : Name or ID of the Log Analytics workspace to send registry diagnostic logs to. All events will be enabled. You can use "az monitor log-analytics workspace create" to create one. Extra billing may apply. Argument '--workspace' is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus

https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/acr/custom.py#L125

savaradh · 2026-02-09T18:32:27Z

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py

+    return RegistryUpdateParameters()
+
+
+def acr_update_set_preview(cmd, client, registry_name, resource_group_name=None, parameters=None):


Should we change the args list to new line as in other methods? Does this fail python formatter check?

The project's pylintrc sets max-line-length=120, so this should be fine and won't fail the lint check

savaradh · 2026-02-09T19:37:34Z

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py

+    from azure.core.exceptions import ResourceNotFoundError, HttpResponseError
+    resource_group_name = get_resource_group_name_by_registry_name(cmd.cli_ctx, registry_name, resource_group_name)
+    try:
+        return client.get(resource_group_name, registry_name)


Why this change? It does not use this fallback in azure-cli repo? Should that be updated as well? Also nit: rearranging the methods order as per the azure-cli repo will help render diff better when doing review. Just a nit

nit: rearranging the methods order as per the azure-cli repo will help render diff better when doing review

Thanks for the suggestion, I will do this next time. I also realized this PR became harder to review after completing the full implementation. I will commit the original azure-cli code first to keep the diff cleaner in the future.

Regarding the function: it now uses the new preview-version client by default (so we can return the regional endpoint fields). The fallback to the standard client ensures that the command still works when the new preview API isn't available, preventing the entire feature from breaking.

savaradh · 2026-02-09T19:39:06Z

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py

+    # Determine the effective SKU (new SKU if being updated, otherwise current SKU)
+    sku = parameters.sku.name if parameters.sku else registry.sku.name
+
+    if parameters.regional_endpoints == RegionalEndpoints.ENABLED:


Should this section be common for all calls? create/update/set? Should it move to _configure_regional_endpoints method?

We had this check on line 218

def _configure_regional_endpoints(cmd, registry, sku, regional_endpoints): if not _check_regional_endpoints_afec(cmd.cli_ctx): raise CLIError( "usage error: The --regional-endpoints parameter is only applicable to" " subscriptions registered with feature {}".format(ACR_AFEC_REGIONAL_ENDPOINT) ) if regional_endpoints == RegionalEndpoints.ENABLED and sku and sku not in get_premium_sku(cmd): raise CLIError(REGIONAL_ENDPOINTS_NOT_SUPPORTED) registry.regional_endpoints = regional_endpoints

I added this additional check because when a user runs az acr update without specifying a SKU, we first need to retrieve the current SKU before performing the validation

src/acrregionalendpoint/azext_acrregionalendpoint/_help.py

yanzhudd · 2026-02-11T03:28:03Z

/azp run

azure-pipelines · 2026-02-11T03:28:18Z

Azure Pipelines successfully started running 2 pipeline(s).

yanzhudd · 2026-02-11T04:05:30Z

Hi @lizMSFT
is this PR ready to review/merge?

[ACR] add new acrregionalendpoint extension for private preview of AC…

b11500c

…R Regional Endpoints feature

Copilot AI review requested due to automatic review settings January 6, 2026 22:09

azure-client-tools-bot-prd bot added this to the February 2026 (2026-02-03) milestone Jan 6, 2026

Copilot started reviewing on behalf of lizMSFT January 6, 2026 22:10 View session

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 6, 2026

Copilot AI reviewed Jan 6, 2026

View reviewed changes

yonzhan requested review from yanzhudd and zhoxing-ms January 6, 2026 23:47

yonzhan assigned zhoxing-ms Jan 6, 2026

fix option_length_too_long

cc477d9

github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 7, 2026

Update HISTORY.rst

ad85d9d

lizMSFT commented Jan 7, 2026

View reviewed changes

lizMSFT commented Jan 12, 2026

View reviewed changes

src/acrregionalendpoint/azext_acrregionalendpoint/_params.py Outdated Show resolved Hide resolved

lizMSFT requested a review from savaradh January 12, 2026 20:21

lizMSFT added 3 commits January 22, 2026 15:53

update parameter name and update to use 2026-01-01-preview api version

d421ef1

fix

40f8029

fix

48a4350

lizMSFT requested a review from Copilot January 29, 2026 00:01

Copilot started reviewing on behalf of lizMSFT January 29, 2026 00:02 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

fix

01b3c16

lizMSFT requested a review from Copilot January 29, 2026 01:51

Copilot started reviewing on behalf of lizMSFT January 29, 2026 01:51 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

src/acrregionalendpoint/azext_acrregionalendpoint/import.py Show resolved Hide resolved

...egionalendpoint/azext_acrregionalendpoint/tests/latest/test_acr_regionalendpoint_scenario.py Show resolved Hide resolved

lizMSFT added 2 commits February 2, 2026 14:40

update az acr login flags

1219d21

update sdk

70af5c8

lizMSFT commented Feb 2, 2026

View reviewed changes

lizMSFT added 2 commits February 5, 2026 11:18

update the test to use prod region instead of euap; add test_acr_comm…

76c0b14

…ands test

update sdk

0db4bd6

huanwu reviewed Feb 6, 2026

View reviewed changes

src/acrregionalendpoint/azext_acrregionalendpoint/_help.py Show resolved Hide resolved

huanwu reviewed Feb 7, 2026

View reviewed changes

src/acrregionalendpoint/azext_acrregionalendpoint/_params.py Show resolved Hide resolved

huanwu reviewed Feb 7, 2026

View reviewed changes

src/acrregionalendpoint/azext_acrregionalendpoint/_help.py Show resolved Hide resolved

huanwu reviewed Feb 7, 2026

View reviewed changes

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py Outdated Show resolved Hide resolved

huanwu reviewed Feb 7, 2026

View reviewed changes

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py Outdated Show resolved Hide resolved

huanwu reviewed Feb 7, 2026

View reviewed changes

src/acrregionalendpoint/azext_acrregionalendpoint/custom.py Show resolved Hide resolved

huanwu reviewed Feb 7, 2026

View reviewed changes

fix comments

9be7c5f

huanwu approved these changes Feb 7, 2026

View reviewed changes

yonzhan assigned yanzhudd Feb 8, 2026

savaradh reviewed Feb 9, 2026

View reviewed changes

add help message for az acr import

24332f4

savaradh approved these changes Feb 9, 2026

View reviewed changes

lizMSFT closed this Feb 12, 2026

		@@ -0,0 +1,401 @@
		# --------------------------------------------------------------------------------------------

		@@ -0,0 +1,184 @@
		# --------------------------------------------------------------------------------------------

		return RegistryUpdateParameters()


		def acr_update_set_preview(cmd, client, registry_name, resource_group_name=None, parameters=None):

Conversation

lizMSFT commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DO NOT MERGE

Related command

Description

Testing

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Jan 6, 2026

Uh oh!

azure-client-tools-bot-prd bot commented Jan 6, 2026

Uh oh!

yonzhan commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huanwu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huanwu left a comment

Choose a reason for hiding this comment

Uh oh!

yanzhudd commented Feb 8, 2026

Uh oh!

azure-pipelines bot commented Feb 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lizMSFT Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lizMSFT commented Jan 6, 2026 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading

lizMSFT Feb 9, 2026 •

edited

Loading