-
Notifications
You must be signed in to change notification settings - Fork 0
Align plugin hooks with current abxpkg API and fix dangling-symlink chmod #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fcc4273
4055744
a674042
6f56b84
a3587fd
bf58d15
5fbe8b8
229d8cf
18ad112
1c90004
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -128,7 +128,7 @@ def test_hook_fails_for_missing_binary_after_command(self): | |||||
|
|
||||||
| # Should fail since binary not found after command | ||||||
| assert result.returncode == 1 | ||||||
| assert "unable to load or install binary nonexistent_binary_xyz123" in ( | ||||||
| assert "unable to install binary nonexistent_binary_xyz123" in ( | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: Fix the expected stderr text to match the hook's actual failure message. Prompt for AI agents
Suggested change
|
||||||
| result.stderr.lower() | ||||||
| ) | ||||||
|
|
||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,18 +67,9 @@ def main( | |
| if not lib_dir: | ||
| lib_dir = str(Path.home() / ".config" / "abx" / "lib") | ||
|
|
||
| configured_cache_dir = (config.PUPPETEER_CACHE_DIR or "").strip() | ||
| if configured_cache_dir: | ||
| browser_cache_dir = Path(configured_cache_dir).expanduser().resolve() | ||
| browser_cache_dir.mkdir(parents=True, exist_ok=True) | ||
| provider = PuppeteerProvider( | ||
| browser_cache_dir=browser_cache_dir, | ||
| browser_bin_dir=browser_cache_dir.parent / "bin", | ||
| ) | ||
| else: | ||
| install_root = (Path(lib_dir) / "puppeteer").resolve() | ||
| install_root.mkdir(parents=True, exist_ok=True) | ||
| provider = PuppeteerProvider(install_root=install_root) | ||
| install_root = (Path(lib_dir) / "puppeteer").resolve() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: This change drops support for Prompt for AI agents |
||
| install_root.mkdir(parents=True, exist_ok=True) | ||
| provider = PuppeteerProvider(install_root=install_root) | ||
|
|
||
| raw_overrides = json.loads(overrides) if overrides else {} | ||
| if not isinstance(raw_overrides, dict): | ||
|
|
@@ -115,7 +106,7 @@ def main( | |
| "binproviders": [provider], | ||
| "overrides": raw_overrides, | ||
| }, | ||
| ).load_or_install() | ||
| ).install() | ||
| except Exception as e: | ||
| error_output = str(e) | ||
| hint = _get_install_failure_hint(error_output) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.