Fix: Monster movement - chapter 4 examples 2 & 3#3
Open
harrider wants to merge 4 commits intoApress:masterfrom
Open
Fix: Monster movement - chapter 4 examples 2 & 3#3harrider wants to merge 4 commits intoApress:masterfrom
harrider wants to merge 4 commits intoApress:masterfrom
Conversation
Added missing condition to prevent movementPoints from decrementing while the monster was moving. Previously if you increased the movementPoints value, it would still only move 1 position, but the movementPoints value would decrement each update frame until it reached 0.
Added missing condition to prevent movementPoints from decrementing while the monster was moving. Previously if you increased the movementPoints value, it would still only move 1 position, but the movementPoints value would decrement each update frame until it reached 0.
Added "moving" attribute to constructor
Added "moving" attribute to constructor
|
Man, you literally saved me like a hundreds of hours to figure out what is wrong. Many thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a missing condition to the "turn()" method in "monster.js" to ensure the monster moves the number of times specified by "movementPoints".
Currently, movementPoints decrements while the monster is moving. If movementPoints' value is relatively low (ie. 1 <= x <= 10), the monster will only move once. If movementPoints' value is relatively high (ie. 20 <= x <= 100), the monster will move more than once, but still less than the value specified by movementPoints.
This change ensures the monster moves "movementPoints" number of times.