This repository was archived by the owner on Jul 28, 2020. It is now read-only.
Open
Conversation
* upstream/master: Bump npm version Change request unique id random generator to a better implementation
|
This also provides iojs compatibility. Is there a chance this pull request gets accepted? |
|
Latest stable version of thrift now would be 0.9.2 @orktes Any updates on this? |
Contributor
|
Thanks for your contributions and sorry for the way too long time to respond. Due to the fact that our long term plan is to deprecate scribe usage inside our own infrastructure we haven't had time to look on this pull request. I will most probably merge this soon and bump minor version number to 0.1.0 |
|
Please update thrift version, current version have issues deal with CJK string. |
|
@garo Any news on this? |
|
0.9.2 is more reasonable for some bugfixs, hope to update |
|
@garo Any news on this? |
|
Bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a unicode issue