Skip to content

[codex] skip approved PRs in stale review reminders#345

Merged
redreceipt merged 1 commit into
mainfrom
codex/skip-approved-review-reminders
May 21, 2026
Merged

[codex] skip approved PRs in stale review reminders#345
redreceipt merged 1 commit into
mainfrom
codex/skip-approved-review-reminders

Conversation

@redreceipt
Copy link
Copy Markdown
Member

Summary

This updates the stale review reminder filter so PRs with GitHub's aggregate reviewDecision of APPROVED are excluded, even when GitHub still has leftover open review requests.

Root cause: the Slack job grouped any open reviewRequests as waiting-for-review work after checks passed. That let approved PRs like ApollosProject/apollos-shovel#1479 appear in the reminder because one requested reviewer was still pending after another reviewer had already approved it.

To Test

  • source .venv-ci/bin/activate && python -m unittest discover -s tests -p 'test_*.py'
  • source .venv-ci/bin/activate && ruff check .
  • source .venv-ci/bin/activate && mypy .
  • git diff --check

Proof

  • Full unit suite passed: 95 tests.
  • Ruff passed.
  • Mypy passed with only existing advisory notes.
  • Diff whitespace check passed.
  • Live GitHub state for ApollosProject/apollos-shovel#1479 confirmed the repro shape: reviewDecision: APPROVED, successful checks, and an open review request still present.

@redreceipt redreceipt temporarily deployed to bug-board-codex-skip-ap-lxd55j May 21, 2026 14:26 Inactive
@redreceipt redreceipt marked this pull request as ready for review May 21, 2026 15:45
@redreceipt redreceipt merged commit 7fdd2f7 into main May 21, 2026
5 checks passed
@redreceipt redreceipt deleted the codex/skip-approved-review-reminders branch May 21, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant