fix: Fix delete partition for transformed partition types#94
Open
fix: Fix delete partition for transformed partition types#94
Conversation
xieandrew
force-pushed
the
78-delete-partition-date
branch
from
925fbac to
b7fd9b8
Compare
xieandrew
force-pushed
the
78-delete-partition-date
branch
from
b7fd9b8 to
cfdab56
Compare
xieandrew
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78 by reading the manifest for transformed partition names instead of column names. It also applies the partition transform to the input if it is a timestamp in order to convert to the Iceberg int representation for time units (e.g. months since epoch).
Examples:
Partitioned by day:
ice delete nyc.taxis_p_by_day --partition '[{"name": "tpep_pickup_datetime_day", "values": ["2024-12-31"]}]'Partitioned by month:
ice delete nyc.taxis_p_by_month --partition '[{"name": "tpep_pickup_datetime_month", "values": ["2025-02-01"]}]'Partitioned by hour:
ice delete nyc.taxis_p_by_hour --partition '[{"name": "tpep_pickup_datetime_hour", "values": ["2025-01-01T03:00:00"]}]'