fix(armor): correct armor count in EKFParameters#35
Merged
creeper5820 merged 1 commit intomainfrom Mar 21, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
漫步移除了 变更
代码审查工作量估计🎯 1 (微小) | ⏱️ ~3 分钟 诗
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable poems in the walkthrough.Disable the |
Closed
creeper5820
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修正装甲板数目的逻辑,移除平衡步兵
修复装甲板数目逻辑
本 PR 修正了
EKFParameters::armor_num()方法中的装甲板计数逻辑。主要改动
在
src/module/predictor/ekf_parameter.hpp文件中,简化了armor_num(DeviceId const&)方法的实现:is_balance及其关联的条件判断分支OUTPOST或BASE的设备现在都统一返回装甲板数为 4当前实现
装甲板计数规则现为:
影响范围
代码改动仅涉及 EKF 参数配置文件,未有公共接口签名变化。