Skip to content

Conversation

@graduta
Copy link
Member

@graduta graduta commented Jan 27, 2026

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

PR which:

  • updates the logic of environment events to use transition status now that ECS is providing it
  • removes the previous use of hardcoded message string comparison
  • Extend EcsOperationAndStepStatus enum with additional ECS statuses (NULL/STARTED/ONGOING).

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates environment event handling to rely on ECS-provided transition status values, removing brittle hardcoded message-string comparisons.

Changes:

  • Switch cache update/removal logic from message string checks to transition.status === DONE_OK.
  • Extend EcsOperationAndStepStatus enum with additional ECS statuses (NULL/STARTED/ONGOING).
  • Update and add unit tests to validate DESTROY removal and clearing isDeploying after successful configure completion.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Control/lib/services/environment/EnvironmentCache.service.js Uses ECS transition status (DONE_OK) for deploy completion and successful destroy removal logic.
Control/lib/common/ecsOperationAndStepStatus.enum.js Adds missing ECS operation/step statuses and links to proto definition.
Control/test/lib/services/environment/mocha-environment-cache.service.test.js Updates existing test to use transition.status and adds coverage for clearing isDeploying on successful configure completion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graduta graduta changed the title [OGUI-1880] Use transition status now that is provided by ECS [OGUI-1880] Use transition status instead of message string comparison by ECS Jan 27, 2026
@graduta graduta merged commit 6928fad into dev Jan 27, 2026
16 of 19 checks passed
@graduta graduta deleted the improv/COG/OGUI-1880/use-transition-status-rather-than-message branch January 27, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants