Skip to content

[PWGUD] flowCorrelationsUpc: use truegapside producer instead of calculating it in the test#16189

Merged
amatyja merged 1 commit into
AliceO2Group:masterfrom
miedema-11:master
May 12, 2026
Merged

[PWGUD] flowCorrelationsUpc: use truegapside producer instead of calculating it in the test#16189
amatyja merged 1 commit into
AliceO2Group:masterfrom
miedema-11:master

Conversation

@miedema-11
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title use truegapside producer [PWGUD] use truegapside producer May 11, 2026
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 11, 2026

Please make it clear in your PR title which part of the framework has changed.

@miedema-11 miedema-11 changed the title [PWGUD] use truegapside producer [PWGUD] use truegapside producer instead of calculating it in the test May 11, 2026
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 11, 2026

Still no mention of the location of the changes in the repo.

@miedema-11
Copy link
Copy Markdown
Contributor Author

Still no mention of the location of the changes in the repo.

I don't understand what do you mean by the location of the repo. The changes of the producer is not contributed by this task. I think my code is completely able to merge

@miedema-11
Copy link
Copy Markdown
Contributor Author

This PR is ready to be merged, thank you

@vkucera vkucera changed the title [PWGUD] use truegapside producer instead of calculating it in the test [PWGUD] flowCorrelationsUpc: use truegapside producer instead of calculating it in the test May 12, 2026
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 12, 2026

Still no mention of the location of the changes in the repo.

I don't understand what do you mean by the location of the repo. The changes of the producer is not contributed by this task. I think my code is completely able to merge

By location, I mean name of the file or task or framework feature. You are supposed to summarise what you changed and where. Otherwise the title is too vague. See the guidelines.

@amatyja amatyja merged commit 82ee952 into AliceO2Group:master May 12, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants