Fix a quoting problem related to CCDB remapping#2166
Merged
shahor02 merged 1 commit intoAliceO2Group:masterfrom Oct 22, 2025
Merged
Fix a quoting problem related to CCDB remapping#2166shahor02 merged 1 commit intoAliceO2Group:masterfrom
shahor02 merged 1 commit intoAliceO2Group:masterfrom
Conversation
The CCDB remapping arguments appeared sometimes correctly quoted and in some cases not. This is because the task_finalizer reapplied string construction/quoting which was not generic enough. This is fixed with this commit. In addition, we now automatically quote ALIEN_JDL_REMAPPING if needed. Both versions ``` export ALIEN_JDL_REMAPPING="foo;bar" ``` as well as (quoted) ``` export ALIEN_JDL_REMAPPING='"foo;bar"' ``` will work. It is recommended to just use the former.
Contributor
Author
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Collaborator
|
Thanks! |
Collaborator
|
Tested locally, works as needed, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CCDB remapping arguments appeared sometimes correctly quoted and in some cases not. This is because the task_finalizer reapplied string construction/quoting which was not generic enough.
This is fixed with this commit.
In addition, we now automatically quote ALIEN_JDL_REMAPPING if needed.
Both versions
as well as (quoted)
will work. It is recommended to just use the former.