Skip to content

[O2B-1524] Add warning icon and tooltip to disabled-gaq-summary #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaachilly merged 5 commits into from
Jan 29, 2026
Merged

[O2B-1524] Add warning icon and tooltip to disabled-gaq-summary #2067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a97cd09
[O2B-1523] Remove GAQ summary from overiew
isaachilly Jan 29, 2026
d54b26c
[O2B-1523] unnecessarily removed gaqNotBadFraction filter
isaachilly Jan 29, 2026
2c6dc20
[O2B1523] Fix indentation in gaqNotBadFraction filter test
isaachilly Jan 29, 2026
94e36ee
[O2B-1524] Add tooltip to GAQ button
isaachilly Jan 29, 2026
db92cb2
Merge branch 'main' into improv/O2B-1524/Add-warning-icon-and-tooltip…
isaachilly Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,13 @@ export const RunsPerDataPassOverviewPage = ({
),
visible: true,
format: (_, { runNumber }) => {
const gaqDisplay = h('button.btn.btn-primary.w-100', 'GAQ');
const gaqDisplay = h('button.btn.btn-primary.w-100', [
'GAQ',
h(
'.d-inline-block.va-t-bottom',
tooltip(h('.f7', iconWarning()), 'GAQ Summary is disabled, please click to view GAQ flags'),
),
]);
return frontLink(gaqDisplay, 'gaq-flags', { dataPassId, runNumber });
},
filter: ({ filteringModel }) => numericalComparisonFilter(
Expand Down
2 changes: 2 additions & 0 deletions test/public/runs/runsPerDataPass.overview.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ module.exports = () => {

await expectInnerText(page, '#row106-globalAggregatedQuality', 'GAQ');

expect(await getPopoverInnerText(await page.waitForSelector('#row106-globalAggregatedQuality .popover-trigger')))
.to.be.equal('GAQ Summary is disabled, please click to view GAQ flags');
});

it('should ignore QC flags created by services in QC summaries of AOT and MUON ', async () => {
Expand Down
Loading