ITSMFT: fix number of rofs per TF #14997
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
shahor02
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the observed fatal (only in local tests, unable to reproduce the hanging in the nightlies).
The error is that due to charge-dependent time-of-arrival digits can migrate beyond the TF.
To be consistent with data (but more importantly to fix the crash), the extra ROF is cut away since it is beyond the actual TF.
Note this only fataled since I added a check that the output of the ROF vector is contiguous and since the accumulated ROFs go beyond the vector, this indexed beyond the expected ROF vector.