Skip to content

Java normalize hostname to lowercase #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitterpanda63 merged 1 commit into from
Mar 16, 2026
Merged

Java normalize hostname to lowercase #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions agent_api/src/main/java/dev/aikido/agent_api/storage/Hostnames.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ protected boolean removeEldestEntry(Map.Entry<String, HostnameEntry> eldest) {
}

public void add(String hostname, int port) {
String key = getKey(hostname, port);
if (hostname == null) return;
String normalizedHostname = hostname.toLowerCase();
String key = getKey(normalizedHostname, port);
if (!map.containsKey(key)) {
map.put(key, new HostnameEntry(hostname, port));
map.put(key, new HostnameEntry(normalizedHostname, port));
}
map.get(key).incrementHits();
}
Expand Down
24 changes: 24 additions & 0 deletions agent_api/src/test/java/storage/HostnamesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,30 @@ public void testExceedMaxEntriesWithMultiplePorts() {
assertTrue(containsEntry(entries, "newsite.com", 3000));
}

@Test
public void testAddNullHostnameIsIgnored() {
hostnames.add(null, 80);
assertEquals(0, hostnames.asArray().length);
}

@Test
public void testAddUppercaseHostnameIsLowercased() {
hostnames.add("EXAMPLE.COM", 80);
Hostnames.HostnameEntry[] entries = hostnames.asArray();
assertEquals(1, entries.length);
assertEquals("example.com", entries[0].getHostname());
}

@Test
public void testMixedCaseAndLowercaseSameEntryDeduplication() {
hostnames.add("Example.COM", 80);
hostnames.add("example.com", 80);
Hostnames.HostnameEntry[] entries = hostnames.asArray();
assertEquals(1, entries.length);
assertEquals("example.com", entries[0].getHostname());
assertEquals(2, entries[0].getHits());
}

private boolean containsEntry(Hostnames.HostnameEntry[] entries, String hostname, int port) {
for (Hostnames.HostnameEntry entry : entries) {
if (entry.getHostname().equals(hostname) && entry.getPort() == port) {
Expand Down
Loading