Fix to keep log cleaner

[dseegers]

No description provided.

[dseegers]

I saw that

if( $field['return_format'] == 'url' )

Was throwing a lot of debug log messages. So maybe it is better to change it to:

if( isset($field['return_format']) && $field['return_format'] == 'url' )

[28-May-2020 12:58:21 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 12:58:21 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 12:58:21 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 12:58:21 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 12:58:21 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 12:58:27 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 13:12:26 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 13:12:26 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 13:12:26 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 13:12:26 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207
[28-May-2020 13:12:26 UTC] PHP Notice:  Undefined index: return_format in /Users/daan/Documents/Development/sites/xxxx/www/wp-content/plugins/advanced-custom-fields-pro/includes/fields/class-acf-field-link.php on line 207

[elliotcondon]

Hi @dseegers

Thanks for the PR.

In theory, It should not be possible for a Link field to be missing the "return_format" property. This prop is added to all Link fields when they are first loaded.

I suspect another variable or bug at play that could be causing the corrupt Link field data.

If it's not too much to ask, can you please spin up a fresh WP site in "Local by Flywheel" and try to replicate the issue? Please keep the default theme active and edit the functions.php file with any extra logic needed.​

​​If you can replicate the issue, please export the site (from flywheel app, right click the site and click "export") and attach to your next reply. ​I'll import this and get to work replicating / testing the issue :)