Open
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (9)
- i18n/bn/docusaurus-plugin-content-docs/current/general/ad-filtering/create-own-filters.md (582-582) There appears to be a contradiction in the documentation. Line 582 states that the `$removeparam` modifier is not supported in AdGuard for Chrome MV3, but line 2741 adds a note saying that `$domain` is not compatible with `$removeparam` in MV3. If `$removeparam` isn't supported at all in MV3, there's no need to specify that it doesn't work with `$domain`.
-
i18n/cs/docusaurus-plugin-content-docs/current/general/ad-filtering/create-own-filters.md (582-582)
This line has been changed from Czech to English. Since this is a Czech translation file, the text should remain in Czech:
V [AdGuardu pro Chrome MV3][ext-mv3] nejsou podporovány domény s `regexp` a `any_tld_domain` a modifikátor `$removeparam`. - i18n/cs/docusaurus-plugin-content-docs/current/general/ad-filtering/create-own-filters.md (2673-2673) This line has been changed from Czech to English. Since this is a Czech translation file, the text should remain in Czech.
- i18n/cs/docusaurus-plugin-content-docs/current/general/ad-filtering/create-own-filters.md (2674-2674) This line has been changed from Czech to English. Since this is a Czech translation file, the text should remain in Czech.
- i18n/cs/docusaurus-plugin-content-docs/current/general/ad-filtering/create-own-filters.md (2741-2741) This line has been changed from Czech to English. Since this is a Czech translation file, the text should remain in Czech.
- i18n/cs/docusaurus-plugin-content-docs/current/general/ad-filtering/create-own-filters.md (2742-2742) This line has been changed from Czech to English. Since this is a Czech translation file, the text should remain in Czech.
- i18n/hr/docusaurus-plugin-content-docs/current/general/ad-filtering/create-own-filters.md (582-582) There appears to be a contradiction in the documentation. Line 582 states that the `$removeparam` modifier is not supported in AdGuard for Chrome MV3, but line 2741 implies that `$removeparam` is supported in MV3 but not compatible with the `$domain` modifier. Please clarify which statement is correct.
- i18n/de/docusaurus-plugin-content-docs/current/general/ad-filtering/create-own-filters.md (582-582) There's an inconsistency in the documentation. Line 2741 states that the `$domain` modifier is not compatible with `$removeparam` in the Manifest V3 extension, but line 582 doesn't mention this limitation - it only lists `regexp` and `any_tld_domain` as unsupported features.
- i18n/uk/docusaurus-plugin-content-docs/current/general/ad-filtering/create-own-filters.md (392-392) The table now shows that `$denyallow` modifier is not supported in AdGuard for iOS, but there's no corresponding explanation in the limitations section. Consider adding details about this limitation to maintain documentation consistency.
💡 To request another review, post a new comment with "/windsurf-review".
|
|
||
| - Регулярные выражения, отрицание и правила белого списка не поддерживаются. | ||
| - Группа похожих правил `$removeparam` будет объединена в одно. Пример: | ||
| - Generic rules are applied before specific rules, and redirection occurs only once. This may prevent subsequent or more specific redirects from applying. |
Contributor
There was a problem hiding this comment.
There's a language inconsistency in the MV3 limitations section. The newly added line (2673) is in English while the surrounding text is in Russian.
| - Регулярные выражения, отрицание и правила белого списка не поддерживаются. | ||
| - Группа похожих правил `$removeparam` будет объединена в одно. Пример: | ||
| - Generic rules are applied before specific rules, and redirection occurs only once. This may prevent subsequent or more specific redirects from applying. | ||
| - Group of similar `$removeparam` rules will be combined into one. Пример: |
Contributor
There was a problem hiding this comment.
This line contains a mix of English and Russian text. For consistency, it should be entirely in Russian since this is the Russian translation file.
|
|
||
| 1. Rules with the `$removeparam` modifier can only be used [**in trusted filters**](#trusted-filters). | ||
| 1. `$removeparam` rules are compatible with [basic modifiers](#basic-rules-basic-modifiers), [content-type modifiers](#content-type-modifiers), and with the `$important` and `$app` modifiers. Rules with any other modifiers are considered invalid and will be discarded. | ||
| 1. Although `$domain` is classified as a basic modifier, it's not compatible with `$removeparam` rules in the Manifest V3 extension. |
Contributor
There was a problem hiding this comment.
The newly added limitation (line 2741) is in English while this is the Russian translation file. It should be translated to Russian for consistency.
|
Preview was deployed to: https://pull-request-830.kb-adg.pages.dev/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transactions are synced from Crowdin