#93 : failures on parsing timestamp with timezone#95
Open
MatloaItumeleng wants to merge 1 commit intomasterfrom
Open
#93 : failures on parsing timestamp with timezone#95MatloaItumeleng wants to merge 1 commit intomasterfrom
MatloaItumeleng wants to merge 1 commit intomasterfrom
Conversation
MatloaItumeleng
requested review from
Zejnilovic,
benedeki,
dk1844,
lsulak and
yruslan
as code owners
|
JaCoCo code coverage report - scala 2.12.20
|
There was a problem hiding this comment.
Pull request overview
This PR fixes timestamp parsing for patterns that include quoted literals (e.g., ISO-8601 yyyy-MM-dd'T'HH:mm:ss.SSSXXX) by correcting how second-fraction section indexes are mapped from the pattern to the input value string, and adds regression tests for the reported failure.
Changes:
- Update
DateTimePatternsecond-fraction scanning to computepatternWithoutSecondFractionsfrom pattern indexes while adjusting extracted/removal section indexes for value strings with quoted literals. - Add a regression test covering parsing of a timezone + milliseconds timestamp with a quoted literal (
'T') in the pattern. - Add a
DateTimePatternunit test validating fraction detection/stripping for the same quoted-literal + timezone pattern.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/scala/za/co/absa/standardization/time/DateTimePattern.scala | Adjusts second-fraction section index handling for patterns containing quoted literals; recomputes patternWithoutSecondFractions from pattern-based sections. |
| src/test/scala/za/co/absa/standardization/types/parsers/DateTimeParserSuite.scala | Adds regression coverage for parsing ISO-like timestamps with timezone + milliseconds and quoted literals in the pattern. |
| src/test/scala/za/co/absa/standardization/time/DateTimePatternSuite.scala | Adds a unit test for second-fraction detection/stripping in quoted-literal + timezone patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+159
to
+163
| def adjust(sectionOpt: Option[Section]): Option[Section] = { | ||
| sectionOpt.map { s => | ||
| val quotesBefore = pat.substring(0, s.start).count(_ == '\'') | ||
| s.copy(start = s.start - quotesBefore) | ||
| } |
Comment on lines
+189
to
+199
| test("DateParser class actual pattern with quoted literal and timezone and milliseconds") { | ||
| val parser = DateTimeParser("yyyy-MM-dd'T'HH:mm:ss.SSSXXX") | ||
| val str = "2025-07-18T16:07:51.569+02:00" | ||
|
|
||
| val resultDate: Date = parser.parseDate(str) | ||
| val expectedDate: Date = Date.valueOf("2025-07-18") | ||
| assert(resultDate == expectedDate) | ||
|
|
||
| val resultTimestamp: Timestamp = parser.parseTimestamp(str) | ||
| val expectedTimestamp: Timestamp = Timestamp.valueOf("2025-07-18 14:07:51.569") | ||
| assert(resultTimestamp == expectedTimestamp) |
ABLL526
reviewed
May 7, 2026
Contributor
ABLL526
left a comment
ABLL526
left a comment
There was a problem hiding this comment.
LGTM, although the Co-Pilot made some valid suggestions that need addressing IMO.
salamonpavel
reviewed
May 7, 2026
salamonpavel
left a comment
salamonpavel
left a comment
There was a problem hiding this comment.
LGTM (read the code), do address Copilot's suggestions otherwise ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes:
closes #93