Feature/167 groups from ldap for entra#168
Merged
Merged
Conversation
… ms entra) with `allow-providers-to-refresh-groups-on-generate: true`
…y vibe-coded, I admit, but checked it)
|
Report: Report: api - scala:2.12.17
|
dk1844
commented
May 14, 2026
| val prefixes = prefixesStr.trim.split(',') | ||
| user.filterGroupsByPrefixes(prefixes.toSet, caseSensitive) | ||
| } | ||
| // groups filtering is pushed down to JWTService as it may be needed for entra-users without groups to have groups added and filtered in the same way |
Collaborator
Author
There was a problem hiding this comment.
This is the get-experimental endpoint.
The fate of it is not decided yet, therefore no generalization effort with the normal post-based token/generate (identical impl now).
This feature is disabled on PROD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature described in #167.
With
loginsvc.rest.jwt.{aws-secrets-manager|generate-in-memory}.allow-providers-to-refresh-groups-on-generate = false, the token without groups (typically coming from MS Entra) may be enriched by groups coming from aUserSearchService(typically LDAP, but ConfigUsers would work, too).Necessary changes added:
Release notes:
Developer testing
Login form UI result with custom groups-prefixes used via MS Entra:


(backend setup includes
allow-providers-to-refresh-groups-on-generate = false, but empty groups were fetched in the MS Entra JWT)Resulting LS access token contains groups now fetched from LDAP based on the
subin the MS Entra JWT:Closes #167