Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/bsk_rl/sim/world.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,6 @@ def setup_ephem_object(self, priority: int = 988, **kwargs) -> None:
self.world_task_name, self.ephemConverter, ModelPriority=priority
)

def __del__(self) -> None:
"""Log when world is deleted and unload SPICE."""
super().__del__()
try:
self.gravFactory.unloadSpiceKernels()
except AttributeError:
pass


class EclipseWorldModel(WorldModel):
def __init__(self, *args, **kwargs) -> None:
Expand Down
7 changes: 0 additions & 7 deletions src/bsk_rl/utils/orbital.py
Original file line number Diff line number Diff line change
Expand Up @@ -551,13 +551,6 @@ def r_BP_P(self) -> interp1d:
fill_value="extrapolate",
)

def __del__(self) -> None:
"""Unload spice kernels when object is deleted."""
try:
self.gravFactory.unloadSpiceKernels()
except AttributeError:
pass


def lla2ecef(lat: float, long: float, radius: float):
"""Project LLA to Earth Centered, Earth Fixed location.
Expand Down
16 changes: 6 additions & 10 deletions tests/unittest/sim/test_world.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,17 +74,13 @@ def test_omega_PN_N(self):
@patch(baseworld + "setup_gravity_bodies")
@patch(baseworld + "setup_ephem_object")
def test_setup_and_delete(self, grav_set, epoch_set):
world = WorldModel(MagicMock(), 1.0)
world = WorldModel(MagicMock(), 1.0) # noqa: F841
for setter in (grav_set, epoch_set):
setter.assert_called_once()
unload_function = MagicMock()
world.gravFactory = MagicMock(unloadSpiceKernels=unload_function)
del world
unload_function.assert_called_once()

@patch(baseworld + "_setup_world_objects", MagicMock())
@patch(module + "simIncludeGravBody", MagicMock())
def testsetup_gravity_bodies(self):
def test_setup_gravity_bodies(self):
# Smoke test
world = WorldModel(MagicMock(), 1.0)
world.simulator = MagicMock()
Expand All @@ -93,7 +89,7 @@ def testsetup_gravity_bodies(self):

@patch(baseworld + "_setup_world_objects", MagicMock())
@patch(module + "ephemerisConverter", MagicMock())
def testsetup_epoch_object(self):
def test_setup_epoch_object(self):
# Smoke test
world = WorldModel(MagicMock(), 1.0)
world.simulator = MagicMock()
Expand All @@ -109,7 +105,7 @@ class TestAtmosphereWorldModel:

@patch(baseworld + "_setup_world_objects", MagicMock())
@patch(module + "exponentialAtmosphere", MagicMock())
def testsetup_atmosphere_density_model(self):
def test_setup_atmosphere_density_model(self):
# Smoke test
world = AtmosphereWorldModel(MagicMock(), 1.0)
world.simulator = MagicMock()
Expand All @@ -129,7 +125,7 @@ class TestEclipseWorldModel:

@patch(baseworld + "_setup_world_objects", MagicMock())
@patch(module + "eclipse", MagicMock())
def testsetup_eclipse_object(self):
def test_setup_eclipse_object(self):
# Smoke test
world = EclipseWorldModel(MagicMock(), 1.0)
world.simulator = MagicMock()
Expand All @@ -151,7 +147,7 @@ def test_setup_world_objects(self, ground_set):

@patch(groundworld + "_setup_world_objects", MagicMock())
@patch(groundworld + "_create_ground_station")
def testsetup_ground_locations(self, mock_gs_create):
def test_setup_ground_locations(self, mock_gs_create):
world = GroundStationWorldModel(MagicMock(), 1.0)
world.setup_ground_locations([dict(a=1), dict(b=2)], 1000.0, 1.0, 1000.0)
mock_gs_create.assert_has_calls(
Expand Down