-
-
Notifications
You must be signed in to change notification settings - Fork 5
Phase1:draft-based notes + safe save/load #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,28 @@ | ||||||
| <!DOCTYPE html> | ||||||
| <html lang="en"> | ||||||
| <head> | ||||||
| <meta charset="UTF-8" /> | ||||||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||||||
| <meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self'; style-src 'self'" /> | ||||||
| <title>Smart Notes MVP</title> | ||||||
| <link rel="stylesheet" href="style.css" /> | ||||||
| </head> | ||||||
| <body> | ||||||
|
|
||||||
| <div id="container"> | ||||||
| <div id="sidebar"> | ||||||
| <button id="new-note">+ New Note</button> | ||||||
| <ul id="notes-list"></ul> | ||||||
| </div> | ||||||
|
|
||||||
| <div id="main-area"> | ||||||
| <div id="editor-toolbar"> | ||||||
| <button id="save-note">💾 Save</button> | ||||||
| </div> | ||||||
| <textarea id="editor" placeholder="Write markdown here..." disabled></textarea> | ||||||
| </div> | ||||||
| </div> | ||||||
|
|
||||||
| <script src="main.js"></script> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Add Placing the script at the end of 🛠️ Proposed fix- <script src="main.js"></script>
+ <script src="main.js" defer></script>📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| </body> | ||||||
| </html> | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Use semantic HTML elements and add explicit
type="button"to buttons.<div>is used for both the sidebar and main area.<aside>and<main>would be semantically correct and improve accessibility. Additionally,<button>elements outside a form technically default totype="submit"per spec — being explicit prevents any unintended behavior.🛠️ Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents