fix: resolve stack overflow in HCL-style test and clippy warnings#27
Merged
Conversation
- Change test_config_supports_hcl_style_provider_blocks to use labeled models block (models "gpt-4.1") instead of unlabeled with id attribute, since a3s_acl parser has issues with unlabeled nested blocks - Remove unnecessary .into() calls in agent_api.rs to fix clippy warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_config_supports_hcl_style_provider_blocksby using labeled models block (models "gpt-4.1") instead of unlabeled with id attribute, since a3s_acl parser has issues with unlabeled nested blocks.into()calls in agent_api.rs to fix clippy warningsTest plan
cargo test -p a3s-code-core --lib test_config_supports_hcl_style_provider_blockspassescargo clippy -p a3s-code-core --libshows no new warningscargo fmt --allpasses