Draft
Conversation
12 SRD 5.2.1 class documents with Zod schema and tests. Schema follows the 2014 structure adapted for 2024 URL conventions. Replaces nyi field in Subclasses with proper class URLs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Note: This PR resolves the Happy to coordinate on merge order or adjust anything to make the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds the 2024 Classes collection — 12 SRD 5.2.1 class documents, a Zod schema, and tests.
src/2024/5e-SRD-Classes.json— All 12 core classes: Barbarian, Bard, Cleric, Druid, Fighter, Monk, Paladin, Ranger, Rogue, Sorcerer, Warlock, Wizardsrc/2024/schemas/5e-SRD-Classes.ts— Zod schema following the same structure as the 2014 schema, adapted for 2024 URL conventionssrc/2024/tests/schemas.test.ts— Classes added to the schema test suitesrc/2024/5e-SRD-Subclasses.json— Replacednyiplaceholder key with properurlin all 12 subclassclassreferencesKnown gaps
The 2024 Proficiencies collection currently only covers Background-relevant proficiencies (14 entries). As a result:
proficienciesarrays are omitted — armor, weapon, and saving-throw proficiencies don't exist in the 2024 collection yetproficiency_choicesuseresource_listformat pointing to/api/2024/proficienciesrather than explicit option arrays, since individual skill/instrument proficiency entries are also missingexplorers-pack,entertainers-pack,spellbook)These gaps should be addressed in a follow-up PR that expands the Proficiencies collection.
How was it tested?
Locally — all 49 tests pass (
vitest run), including the schema validation test and the broken-link tables test.Is there a Github issue this is resolving?
No
Did you update the docs in the API? Please link an associated PR if applicable.
No