Closed
Conversation
Remove deploy (MongoDB update) and trigger-downstream jobs — the fork
has no hosted API. Consolidate into a single container-release job that
builds and pushes ghcr.io/t11z/5e-database:{tag} + :latest on release
publish or manual dispatch.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ci: adapt release workflow for t11z fork
Fork manages releases manually; the workflow requires GitHub App secrets (DEPLOYMENT_APP_ID / DEPLOYMENT_APP_PRIVATE_KEY) that aren't available here. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ci: disable release-please workflow in fork
12 SRD 5.2.1 class documents with Zod schema and tests. Schema follows the 2014 structure adapted for 2024 URL conventions. Replaces nyi field in Subclasses with proper class URLs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feat(2024): add Classes collection
Author
|
Reopening with a clean branch — this one included fork-specific CI commits. See replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds the Classes collection to the 2024 dataset — 12 SRD 5.2.1 class documents, a Zod schema, and tests.
Files:
src/2024/5e-SRD-Classes.json— all 12 SRD classessrc/2024/schemas/5e-SRD-Classes.ts— Zod schema based on the 2014 structure, adapted for 2024 URLssrc/2024/tests/schemas.test.tssrc/2024/5e-SRD-Subclasses.json— replacednyifield with properurlin all 12 class references (the data they point to now exists)2024-specific changes vs 2014:
spellcasting.levelchanged from 2 to 1 (SRD 5.2.1 p. 57)/api/2024/prefix5e-SRD-Subclasses.jsonOpen question — Starting Equipment format:
The 2024 SRD presents starting equipment as a single A/B choice per class. The current JSON retains the 2014 granular structure. Happy to refactor to the 2024 A/B bundle format (as used in Backgrounds) if that's preferred — kept it conservative to avoid making a schema decision in isolation.
Relationship to #1056: This PR resolves the
/api/2024/classes/{class}-nyireferences in the Features PR by @G-Ambatte.How was it tested?
npm testpasses. Spot-checked 10 of 12 classes against the SRD 5.2.1 PDF (hit dice, saving throws, spellcasting, multiclassing prerequisites, skill choices, subclass references).Is there a Github issue this is resolving?
No existing issue. This fills a gap in the 2024 dataset — Classes was one of the missing collections alongside Levels, Spells, and Monsters.
Did you update the docs in the API? Please link an associated PR if applicable.
No — the API doesn't serve
/api/2024yet. Once the API adds 2024 class endpoints, the data from this PR will be ready to serve.Here's a fun image for your troubles