fix(store): network notes must be public [main]#1736
Merged
Mirko-von-Leipzig merged 5 commits intomainfrom Mar 3, 2026
Merged
Conversation
Mirko-von-Leipzig
changed the title
Mirko-von-Leipzig
force-pushed
the
mirko/fix-networknote-main
branch
from
32af1a1 to
eb5ebf4
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/fix-networknote-main
branch
from
eb5ebf4 to
80a8c17
Compare
drahnr
reviewed
Mar 3, 2026
| use QueryParamNoteIdLimit as NoteId; | ||
| use QueryParamNoteTagLimit as NoteTag; | ||
| use QueryParamNullifierLimit as Nullifier; | ||
| use QueryParamStorageMapKeyTotalLimit as StorageMapKeyTotal; |
Contributor
There was a problem hiding this comment.
depending on your toolchain / component version this diff flip-flops
drahnr
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1726 fix on
main.This includes automatically fixing existing misclassified entries in the database on startup.