feat: move rocksdb backend for LargeSmt from -crypto to -node#1499
Merged
feat: move rocksdb backend for LargeSmt from -crypto to -node#1499
rocksdb backend for LargeSmt from -crypto to -node#1499Conversation
drahnr
force-pushed
the
bernhard-migrate-rocksdb-from-crypto
branch
from
b962eda to
46708e6
Compare
drahnr
added
blocked
drahnr
changed the title
rocksdb backend for LargeSmtrocksdb backend for LargeSmt from -crypto to -node
drahnr
force-pushed
the
bernhard-migrate-rocksdb-from-crypto
branch
from
46708e6 to
594aa40
Compare
drahnr
added
the
no changelog
krushimir
reviewed
Feb 27, 2026
krushimir
reviewed
Feb 27, 2026
krushimir
reviewed
Feb 27, 2026
krushimir
reviewed
Feb 27, 2026
krushimir
reviewed
Feb 27, 2026
Contributor
Author
|
The remaining CI failure is unrelated and addressed in #1723 |
sergerad
reviewed
Mar 3, 2026
sergerad
approved these changes
Mar 3, 2026
Collaborator
sergerad
left a comment
sergerad
left a comment
There was a problem hiding this comment.
LGTM just the Cargo.toml needs a cleanup I think
…e-rocksdb-from-crypto
krushimir
approved these changes
Mar 3, 2026
krushimir
left a comment
krushimir
left a comment
There was a problem hiding this comment.
Only a minor doc nit, otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Copies the RocksDB backend implementation to the
miden-noderepo.Closes #1218
Prerequisites
Requires 0xMiden/crypto#850 + a release of
miden-crypto @ 0.19.x.