Skip to content

Disabled logs that had a risk of sensitive information #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjacquot1 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Disabled logs that had a risk of sensitive information #3003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apis_v1/views/views_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,8 +632,9 @@ def firebase_notification_send_to_cordova_apps(we_vote_id, speaker_name, stateme
for device in device_list:
send_single_message(device.platform_type, device.firebase_fcm_token, "We Vote", body,
badge_number)
logger.info('firebase_notification_send_to_cordova_apps sent : ' + device.platform_type +
device.firebase_fcm_token + "We Vote" + body + str(badge_number))
# Disabled due to logging possible sensitive data
# logger.info('firebase_notification_send_to_cordova_apps sent : ' + device.platform_type +
# device.firebase_fcm_token + "We Vote" + body + str(badge_number))
except Exception as e:
logger.error('firebase_notification_send_to_cordova_apps threw: ', e)
end = str(time.time() - start)
Expand Down
3 changes: 2 additions & 1 deletion aws/management/commands/runsqsworker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@
MAX_JOB_RETRY_ATTEMPTS = 5

def process_request(function, body, message):
logger.info('(Ok) SQS job execute process_request ' + function + ' ' + str(body))
# Disabled due to logging possible sensitive information
# logger.info('(Ok) SQS job execute process_request ' + function + ' ' + str(body))

if function == 'caching_facebook_images_for_retrieve_process':
from import_export_facebook.controllers import caching_facebook_images_for_retrieve_process
Expand Down
3 changes: 2 additions & 1 deletion donate/controllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,8 @@ def donation_process_charge(event): # 'charge.succeeded'
voter_we_vote_id = charge['metadata']['voter_we_vote_id']
if voter_we_vote_id:
# Has our metadata? Then we have already made a journal entry at the time of the donation
logger.info("Stripe 'charge.succeeded' received for a PAYMENT_FROM_UI -- ignored, charge = " + charge)
# Disabled due to logging possible sensitive information
# logger.info("Stripe 'charge.succeeded' received for a PAYMENT_FROM_UI -- ignored, charge = " + charge)
return
except Exception:
voter_we_vote_id = DonationManager.find_we_vote_voter_id_for_stripe_customer(customer)
Expand Down
6 changes: 4 additions & 2 deletions donate/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1676,8 +1676,10 @@ def update_subscription_with_latest_charge_date(invoice_id, invoice_date):
how_many_days= 10
queryset = DonationInvoice.objects.filter(invoice_date__lte=datetime.fromtimestamp(
int(time.time()), timezone.utc) - timedelta(days=how_many_days))
logger.info("update_subscription_with_latest_charge_date: DELETED " + str(queryset.count()) +
" invoice rows that were older than " + str(how_many_days) + " days old.")

# Disabled due to logging possible sensitive information
# logger.info("update_subscription_with_latest_charge_date: DELETED " + str(queryset.count()) +
# " invoice rows that were older than " + str(how_many_days) + " days old.")
queryset.delete()

except Exception as e:
Expand Down
5 changes: 3 additions & 2 deletions import_export_facebook/controllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,8 +746,9 @@ def update_organization_facebook_images(facebook_user_id, facebook_profile_image
if organization_updated:
try:
organization.save()
logger.info("update_organization_facebook_images saved updated images for organization: " +
organization.we_vote_id + ", facebook_id: " + str(organization.facebook_id))
# Disabled due to logging possible sensitive information
# logger.info("update_organization_facebook_images saved updated images for organization: " +
# organization.we_vote_id + ", facebook_id: " + str(organization.facebook_id))
return
except Exception as e:
logger.error("update_organization_facebook_images threw: " + str(e))
Expand Down
3 changes: 2 additions & 1 deletion organization/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2340,7 +2340,8 @@ def update_organization_single_voter_data(twitter_user_id,
results = organization_manager.retrieve_organization(twitter_user_id=twitter_user_id)

if not results['organization_found']:
logger.info("update_organization_single_voter_data was not able to find " + str(twitter_user_id))
# Disabled due to logging possible sensitive information
# logger.info("update_organization_single_voter_data was not able to find " + str(twitter_user_id))
return False
try:
organization = results['organization']
Expand Down
6 changes: 4 additions & 2 deletions stripe_donations/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2049,7 +2049,8 @@ def retrieve_chip_in_total(voter_wevote_id, campaignx_we_vote_id):
return 'none'

except Exception as e:
logger.info("FAILED_TO RETRIEVE_DONATION_PAYMENT_LIST ", e)
# Disabled due to logging possible sensitive information
# logger.info("FAILED_TO RETRIEVE_DONATION_PAYMENT_LIST ", e)
return 'none'

@staticmethod
Expand Down Expand Up @@ -2080,7 +2081,8 @@ def retrieve_payments_total(voter_wevote_id):
return 'none'

except Exception as e:
logger.info("FAILED_TO RETRIEVE_DONATION_PAYMENT_LIST ", e)
# Disabled due to logging possible sensitive information
# logger.info("FAILED_TO RETRIEVE_DONATION_PAYMENT_LIST ", e)
return 'none'


Expand Down
3 changes: 2 additions & 1 deletion voter/controllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,8 @@ def delete_all_voter_information_permanently(voter_to_delete=None, user=None):
except Exception as e:
log += 'LOGGING_PROBLEM ' + str(e) + " "
log += 'STATUS: ' + status + ' '
logger.info(log)
# Disabled due to logging possible sensitive information
# logger.info(log)

results = {
'status': status,
Expand Down
3 changes: 2 additions & 1 deletion wevote_social/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,8 @@ def social_user(backend, uid, details, user=None, *args, **kwargs):
def switch_user(backend, switch_user=False, user=None, social=None, *args, **kwargs):

if switch_user and social:
logger.warning('[authplus.social_pipeline.switch_user] switch to user %s' % user.email)
# Disabled due to logging possible sensitive information
# logger.warning('[authplus.social_pipeline.switch_user] switch to user %s' % user.email)

# Do we have a voter who's twitter_id matches the incoming user_id?
# Is social.user_id the Twitter id?
Expand Down