Skip to content

Commit b1e2967

Browse files
committed
fix(core,sdk): add typesVersions entry for v3/sdk-scope-storage + move taskContext cleanup to afterEach
`attw --pack` (check-exports) was failing on the new `@trigger.dev/core/v3/sdk-scope-storage` sub-path under node10 resolution because the export had no matching `typesVersions` mapping. Added one alongside the existing per-sub-path entries. In `triggerClient.test.ts`, moved `taskContext.disable()` from inside the individual taskContext-masking tests into the shared `afterEach` so a failing assertion can't leak a stubbed global task context into later tests in the file.
1 parent abf9f3c commit b1e2967

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/core/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,9 @@
163163
"v3/isomorphic": [
164164
"dist/commonjs/v3/isomorphic/index.d.ts"
165165
],
166+
"v3/sdk-scope-storage": [
167+
"dist/commonjs/v3/sdkScope/storage-node.d.ts"
168+
],
166169
"v3/test": [
167170
"dist/commonjs/v3/test/index.d.ts"
168171
]

packages/trigger-sdk/src/v3/triggerClient.test.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ describe("TriggerClient", () => {
4848
afterEach(() => {
4949
fetchSpy.restore();
5050
apiClientManager.disable();
51+
taskContext.disable();
5152
vi.unstubAllEnvs();
5253
});
5354

@@ -152,8 +153,6 @@ describe("TriggerClient", () => {
152153
);
153154

154155
expect(observed).toBeUndefined();
155-
156-
taskContext.disable();
157156
});
158157

159158
it("exposes taskContext.ctx inside a scope when inheritContext is true", () => {
@@ -171,8 +170,6 @@ describe("TriggerClient", () => {
171170
);
172171

173172
expect(observed).toBe(fakeCtx);
174-
175-
taskContext.disable();
176173
});
177174
});
178175

0 commit comments

Comments
 (0)