Change client stream server api (#6)

Author: kafkiansky

README.md

@@ -429,7 +429,11 @@ interface QueueServiceServer
     /**
      * @param Server\ClientStreamChannel<\Thesis\Api\V1\Message, \Google\Protobuf\Empty_> $stream
      */
-    public function push(Server\ClientStreamChannel $stream, Metadata $md, Cancellation $cancellation): void;
+    public function push(
+        Server\ClientStreamChannel $stream,
+        Metadata $md,
+        Cancellation $cancellation,
+    ): \Google\Protobuf\Empty_;
 
     /**
      * @param Server\ServerStreamChannel<\Google\Protobuf\Empty_, \Thesis\Api\V1\Message> $stream

src/Plugin/Generator/GrpcGenerator.php

@@ -248,7 +248,7 @@ public function generateServer(Parser\ServiceDescriptor $service): PhpNamespace
                         new Parameter('md')->setType('Metadata'),
                         new Parameter('cancellation')->setType('Cancellation'),
                     ])
-                    ->setReturnType('void')
+                    ->setReturnType($out->fqcn)
                     ->addComment("{$phpdocPrefix}@param Server\\ClientStreamChannel<{$in->fqcn}, {$out->fqcn}> \$stream");
             } elseif (!$method->clientStreaming && $method->serverStreaming) {
                 $interfaceMethod

tests/CompilerTest.php

@@ -1706,7 +1706,11 @@ interface QueueServiceServer
     /**
      * @param Server\ClientStreamChannel<\Thesis\Queue\PushRequest\Message, \Google\Protobuf\Empty_> $stream
      */
-    public function push(Server\ClientStreamChannel $stream, Metadata $md, Cancellation $cancellation): void;
+    public function push(
+        Server\ClientStreamChannel $stream,
+        Metadata $md,
+        Cancellation $cancellation,
+    ): \Google\Protobuf\Empty_;
 
     /**
      * @param Server\ServerStreamChannel<\Thesis\Queue\PullRequest, \Thesis\Queue\PullRequest\Message> $stream