Skip to content

Polish Widgets Foundation #936

@ovitrif

Description

@ovitrif

Found a couple of UI nits worth polishing in another PR:

Part 1

1. Bg Color Issue

Screen in AppWidgetConfigActivity doesn't have same BG color as the bitkit app, apparently.

While that's not the main issue, it leads to these visible differences in bg between system bars and app bg:

Widgets Activity App Activity

Most likely the fix is to enable edge to edge like we do in MainActivity.kt#L89

enableAppEdgeToEdge()
// setContent {
//

2. New Select Option UI Control Jump

There's a slightly visible jump on UI when changing widget options using the new select component, visible on tap:

uiglitch.mp4

Originally posted by @ovitrif in #895 (review)


Part 2

I've approved all individual stacked PRs. I think it looks good functionally. Also e2e tests updated to cover in app redesigned widgets.

There are some outstanding items that I think would be good to address before releasing this feature:

  • behavior described here: feat: headlines widget v61 + OS widget #919 (comment) (seems to concern all OS widgets)
  • if possible consider ordering suggestion of OS widgets on add screen (IMHO price, blocks, weather could be on top if possible)
  • in app small widget support... either support it in app view or remove small preview for now. Otherwise it may be a bit confusing as why only wide version is supported despite saving the small one.

Originally posted by @piotr-iohk in #895 (comment)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions