Skip to content

Wire v6.1 - time range check breaks app #3560

@AlexanderEggers

Description

@AlexanderEggers

When using Wire v6.1, the app breaks in a lot of different places due to this change:

Validate Timestamp during serialization that values are within spec's range (#3550)

Error message:

Timestamp seconds (-3217862419201) must be in range [-62135596800, 253402300799]

We are using kotlin's Instant.DISTANT_PAST for certain default values and converting those cases to java's Instant (via Kotlin's toJavaInstant) when using GRPC.

I potentially agree that this is an issue for me to resolve but I would also argue that this is a breaking behaviour change and should not be part of a minor release.
Could you please consider putting this behind a feature flag so that projects like mine could slowly adopt to that new spec range check instead of preventing us to keep using newer versions of wire?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions