Skip to content

Commit d54cf4b

Browse files
waleedlatif1claude
andcommitted
refactor(knowledge): remove duplicate extension list from parser-extension
Use SUPPORTED_DOCUMENT_EXTENSIONS and isSupportedExtension from validation.ts instead of maintaining a separate identical list. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 05d8c18 commit d54cf4b

File tree

1 file changed

+9
-27
lines changed

1 file changed

+9
-27
lines changed

apps/sim/lib/knowledge/documents/parser-extension.ts

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,11 @@
11
import { getExtensionFromMimeType } from '@/lib/uploads/utils/file-utils'
2-
import { isAlphanumericExtension } from '@/lib/uploads/utils/validation'
2+
import {
3+
isAlphanumericExtension,
4+
isSupportedExtension,
5+
SUPPORTED_DOCUMENT_EXTENSIONS,
6+
} from '@/lib/uploads/utils/validation'
37

4-
const SUPPORTED_FILE_TYPES = [
5-
'pdf',
6-
'csv',
7-
'docx',
8-
'doc',
9-
'txt',
10-
'md',
11-
'xlsx',
12-
'xls',
13-
'pptx',
14-
'ppt',
15-
'html',
16-
'htm',
17-
'json',
18-
'yaml',
19-
'yml',
20-
] as const
21-
22-
const SUPPORTED_FILE_TYPES_TEXT = SUPPORTED_FILE_TYPES.join(', ')
23-
24-
function isSupportedParserExtension(extension: string): boolean {
25-
return SUPPORTED_FILE_TYPES.includes(extension as (typeof SUPPORTED_FILE_TYPES)[number])
26-
}
8+
const SUPPORTED_EXTENSIONS_TEXT = SUPPORTED_DOCUMENT_EXTENSIONS.join(', ')
279

2810
export function resolveParserExtension(
2911
filename: string,
@@ -33,12 +15,12 @@ export function resolveParserExtension(
3315
const raw = filename.includes('.') ? filename.split('.').pop()?.toLowerCase() : undefined
3416
const filenameExtension = raw && isAlphanumericExtension(raw) ? raw : undefined
3517

36-
if (filenameExtension && isSupportedParserExtension(filenameExtension)) {
18+
if (filenameExtension && isSupportedExtension(filenameExtension)) {
3719
return filenameExtension
3820
}
3921

4022
const mimeExtension = mimeType ? getExtensionFromMimeType(mimeType) : undefined
41-
if (mimeExtension && isSupportedParserExtension(mimeExtension)) {
23+
if (mimeExtension && isSupportedExtension(mimeExtension)) {
4224
return mimeExtension
4325
}
4426

@@ -48,7 +30,7 @@ export function resolveParserExtension(
4830

4931
if (filenameExtension) {
5032
throw new Error(
51-
`Unsupported file type: ${filenameExtension}. Supported types are: ${SUPPORTED_FILE_TYPES_TEXT}`
33+
`Unsupported file type: ${filenameExtension}. Supported types are: ${SUPPORTED_EXTENSIONS_TEXT}`
5234
)
5335
}
5436

0 commit comments

Comments
 (0)