fixtest: GET my dynamic entity endpoint gets records the user created,

simonredfern · simonredfern · commit 6e2d7cbbab54 · 2026-01-21T09:42:47.000+01:00
not just records with hasPersonalEntity=true. Previous behaviour was
confusing.
diff --git a/obp-api/src/test/scala/code/api/v4_0_0/DynamicEntityTest.scala b/obp-api/src/test/scala/code/api/v4_0_0/DynamicEntityTest.scala
@@ -1725,20 +1725,20 @@ class DynamicEntityTest extends V400ServerSetup {
       }
 
       {
-        Then("User1 get my foobar, only return his own records, only one")
+        Then("User1 get my foobar, returns his own records (including those created via non-/my endpoints)")
         val requestGetFoobars = (dynamicEntity_Request / "my" / "FooBar").GET <@ (user1)
         val responseGetFoobars = makeGetRequest(requestGetFoobars)
         responseGetFoobars.code should equal(200)
 
-        (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(1)
+        (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(2)
       }
       {
-        Then("User2 get my foobar, only return his own records, only one")
+        Then("User2 get my foobar, returns his own records (including those created via non-/my endpoints)")
         val requestGetFoobars = (dynamicEntity_Request / "my" / "FooBar").GET <@ (user2)
         val responseGetFoobars = makeGetRequest(requestGetFoobars)
         responseGetFoobars.code should equal(200)
 
-        (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(1)
+        (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(2)
       }
 
       {
@@ -1851,20 +1851,20 @@ class DynamicEntityTest extends V400ServerSetup {
       }
 
       {
-        Then("User1 get my foobar, only return his own records, only one")
+        Then("User1 get my foobar, returns his own records (including those created via non-/my endpoints)")
         val requestGetFoobars = (dynamicEntity_Request / "banks" / testBankId1.value / "my" / "FooBar").GET <@ (user1)
         val responseGetFoobars = makeGetRequest(requestGetFoobars)
         responseGetFoobars.code should equal(200)
 
-        (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(1)
+        (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(2)
       }
       {
-        Then("User2 get my foobar, only return his own records, only one")
+        Then("User2 get my foobar, returns his own records (including those created via non-/my endpoints)")
         val requestGetFoobars = (dynamicEntity_Request / "banks" / testBankId1.value / "my" / "FooBar").GET <@ (user2)
         val responseGetFoobars = makeGetRequest(requestGetFoobars)
         responseGetFoobars.code should equal(200)
 
-        (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(1)
+        (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(2)
       }
 
       {

Original file line number	Diff line number	Diff line change
`@@ -1725,20 +1725,20 @@ class DynamicEntityTest extends V400ServerSetup {`
`1725`	`1725`	`}`
`1726`	`1726`
`1727`	`1727`	`{`
`1728`		`- Then("User1 get my foobar, only return his own records, only one")`
	`1728`	`+ Then("User1 get my foobar, returns his own records (including those created via non-/my endpoints)")`
`1729`	`1729`	`val requestGetFoobars = (dynamicEntity_Request / "my" / "FooBar").GET <@ (user1)`
`1730`	`1730`	`val responseGetFoobars = makeGetRequest(requestGetFoobars)`
`1731`	`1731`	`responseGetFoobars.code should equal(200)`
`1732`	`1732`
`1733`		`- (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(1)`
	`1733`	`+ (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(2)`
`1734`	`1734`	`}`
`1735`	`1735`	`{`
`1736`		`- Then("User2 get my foobar, only return his own records, only one")`
	`1736`	`+ Then("User2 get my foobar, returns his own records (including those created via non-/my endpoints)")`
`1737`	`1737`	`val requestGetFoobars = (dynamicEntity_Request / "my" / "FooBar").GET <@ (user2)`
`1738`	`1738`	`val responseGetFoobars = makeGetRequest(requestGetFoobars)`
`1739`	`1739`	`responseGetFoobars.code should equal(200)`
`1740`	`1740`
`1741`		`- (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(1)`
	`1741`	`+ (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(2)`
`1742`	`1742`	`}`
`1743`	`1743`
`1744`	`1744`	`{`
`@@ -1851,20 +1851,20 @@ class DynamicEntityTest extends V400ServerSetup {`
`1851`	`1851`	`}`
`1852`	`1852`
`1853`	`1853`	`{`
`1854`		`- Then("User1 get my foobar, only return his own records, only one")`
	`1854`	`+ Then("User1 get my foobar, returns his own records (including those created via non-/my endpoints)")`
`1855`	`1855`	`val requestGetFoobars = (dynamicEntity_Request / "banks" / testBankId1.value / "my" / "FooBar").GET <@ (user1)`
`1856`	`1856`	`val responseGetFoobars = makeGetRequest(requestGetFoobars)`
`1857`	`1857`	`responseGetFoobars.code should equal(200)`
`1858`	`1858`
`1859`		`- (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(1)`
	`1859`	`+ (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(2)`
`1860`	`1860`	`}`
`1861`	`1861`	`{`
`1862`		`- Then("User2 get my foobar, only return his own records, only one")`
	`1862`	`+ Then("User2 get my foobar, returns his own records (including those created via non-/my endpoints)")`
`1863`	`1863`	`val requestGetFoobars = (dynamicEntity_Request / "banks" / testBankId1.value / "my" / "FooBar").GET <@ (user2)`
`1864`	`1864`	`val responseGetFoobars = makeGetRequest(requestGetFoobars)`
`1865`	`1865`	`responseGetFoobars.code should equal(200)`
`1866`	`1866`
`1867`		`- (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(1)`
	`1867`	`+ (responseGetFoobars.body \ "foo_bar_list").asInstanceOf[JArray].arr.size should be(2)`
`1868`	`1868`	`}`
`1869`	`1869`
`1870`	`1870`	`{`