[CLNP-6463][fix]: fix scroll pagination failing after offline or search query change #1416
Open
sf-tyler-jeong wants to merge 4 commits intomainfrom
Open
[CLNP-6463][fix]: fix scroll pagination failing after offline or search query change #1416sf-tyler-jeong wants to merge 4 commits intomainfrom
sf-tyler-jeong wants to merge 4 commits intomainfrom
Conversation
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcb1638cf7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MessageSearch scroll pagination that breaks after going offline or changing the search query.
Root cause:
useScrollCallbackcaptured a stalecurrentMessageSearchQueryin itsuseCallbackclosurehasMoreResultstate could become stale, blocking further paginationChanges (
useScrollCallback.ts):useRefto always access the latestcurrentMessageSearchQuerywithout re-creating the callbacknavigator.onLine) to skip loading when disconnectedisLoadingguard to prevent duplicate concurrent requestshasMoreResultstate; usequery.hasNextdirectly from the live query objectuseCallbackwith empty dependency array since all state is accessed via refTest changes (useScrollCallback.spec.ts):
Fixes CLNP-6463
Changelogs
Checklist