rustfmt deletes vertical bar for match branches!

[rusterize]

The vertical bar for match brances was just stabilized, but rustfmt deletes them.

Thanks for the great work.

[topecongiro]

The stabilization PR removed beginning_vert field from ast::Arm. We need to bring it back to support it in rustfmt.

[topecongiro]

Note that rustfmt will not remove the vertical bar at the beginning of march arms, but it will not format the entire arm with the beginning vertical bar.

@rusterize Would you tell us which version of rustfmt you are using please? I think you might be using older version of rustfmt.

[rusterize]

$ rustfmt --version
0.3.8-nightly (346238f 2018-02-04)

[topecongiro]

@rusterize Thanks! You are using the latest rustfmt, so I assume that the removal of the vertical bar happens in non-simple cases.

Could you please share your code that caused the removal of the vertical bar?

[rusterize]

Before rustfmt:

        match anchor {
            | &Some(ref row_index) => Ok(row_nodes_borrow
                .get(row_index)
                .ok_or(RowIndexNotFound(format!("{}", row_index)))?),

            | &None => Ok(&self.root_node_iter),
        }

after rustfmt:

        match anchor {
            &Some(ref row_index) => Ok(row_nodes_borrow
                .get(row_index)
                .ok_or(RowIndexNotFound(format!("{}", row_index)))?),
            |
            &None => Ok(&self.root_node_iter),
        }

[topecongiro]

@rusterize Thank you for sharing the code! I could confirm the issue. And it should be fixed with #2464.

[nrc]

I'm not 100% sure what Rustfmt should be doing here, see rust-lang/style-team#119, however, it is clear the current behaviour is bad so I've merged the fixing PR.